Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputInline has broken scroll in Safari & Firefox #9818

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Nov 22, 2024

Fixes #7552

@nsbarsukov nsbarsukov self-assigned this Nov 22, 2024
Copy link

lumberjack-bot bot commented Nov 22, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Visit the preview URL for this PR (updated for commit e3458e0):

https://taiga-previews-demo--pr9818-input-inline-fix-demo-z3s7dm20.web.app

(expires Sat, 07 Dec 2024 12:20:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Nov 22, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
43.82KB (+42B +0.09%) +10%
demo/browser/main.(hash).js
303.76KB (-73B -0.02%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.11KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -31B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.32MB (+7.47KB +0.1%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Playwright test results

failed  3 failed
passed  970 passed
flaky  2 flaky

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  8 minutes, 41 seconds
commit  e3458e0

Failed tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/input-range
chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /charts/ring-chart
chromium › tests/demo/demo.pw.spec.ts › Demo › /components/input-inline

Flaky tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/calendar-month
chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/icon

@nsbarsukov nsbarsukov changed the title [WIP] fix(kit): InputInline has broken scroll in Safari & Firefox fix(kit): InputInline has broken scroll in Safari & Firefox Dec 2, 2024
@nsbarsukov nsbarsukov marked this pull request as ready for review December 2, 2024 11:05
@nsbarsukov nsbarsukov requested a review from a team as a code owner December 2, 2024 11:05
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team December 2, 2024 11:05
@nsbarsukov nsbarsukov requested a review from splincode December 3, 2024 10:43
@splincode splincode merged commit 76634f1 into main Dec 6, 2024
25 of 26 checks passed
@splincode splincode deleted the input-inline-fix branch December 6, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - InputInline has broken scroll in Safari / Firefox
3 participants