Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): InputInline has broken scroll in Safari & Firefox #9947

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(kit): InputInline has broken scroll in Safari & Firefox #9947

merged 2 commits into from
Dec 10, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Dec 9, 2024 •
edited
Loading

Fixes #7552
Closes UIKIT-7683

Cherry-pick:

Previous behavior

New behavior

@nsbarsukov nsbarsukov added the v3 label Dec 9, 2024
@nsbarsukov nsbarsukov self-assigned this Dec 9, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 9, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon BundleMon
Copy link

bundlemon bot commented Dec 9, 2024 •
edited
Loading

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +397.61KB +10%
✅ demo/browser/vendor.(hash).js
 +214.53KB +10%
✅ demo/browser/runtime.(hash).js
 +42.11KB +10%
✅ demo/browser/polyfills.(hash).js
 +15.2KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +670.84KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.46MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e480b6b):

https://taiga-ui--pr9947-input-inline-fix-8f5vw9f4.web.app

(expires Tue, 10 Dec 2024 14:56:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@nsbarsukov nsbarsukov marked this pull request as ready for review December 9, 2024 14:51
@splincode splincode merged commit ac13a6f into v3.x Dec 10, 2024
32 of 33 checks passed
@splincode splincode deleted the input-inline-fix branch December 10, 2024 10:55
@taiga-family-bot taiga-family-bot mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsbarsukov @waterplea @splincode