chore(demo): use baseHref=/ instead of baseHref=./
#8526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
Visit the preview URL for this PR (updated for commit 4771a35): https://taiga-ui--pr8526-base-href-refactor-v-utvbz43n.web.app (expires Thu, 15 Aug 2024 17:46:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (3)
Unchanged files (2)
Total files change +5.3KB +0.8% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
nsbarsukov
force-pushed
the
base-href-refactor-v3
branch
from
c60db69 to
028ab8a
Compare
nsbarsukov
force-pushed
the
base-href-refactor-v3
branch
from
0b47990 to
68e5a8c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.x #8526 +/- ##
=======================================
Coverage ? 66.54%
=======================================
Files ? 199
Lines ? 2203
Branches ? 278
=======================================
Hits ? 1466
Misses ? 701
Partials ? 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nsbarsukov
commented
Aug 14, 2024
Comment on lines
-63
to
+64
| useFactory: () => inject(DOCUMENT).querySelector('base')?.href || '/', | ||
| useFactory: () => | ||
| inject(DOCUMENT).querySelector('base')?.getAttribute('href') || '/', |
There was a problem hiding this comment.
<base href="/v3/">document.querySelector('base').href; // https://taiga-ui.dev/v3/
document.querySelector('base').getAttribute('href'); // /v3/
nsbarsukov
changed the title
baseHref=/ instead of baseHref=./baseHref=/ instead of baseHref=./
mdlufy
approved these changes
Aug 14, 2024
nsbarsukov
changed the title
baseHref=/ instead of baseHref=./baseHref=/ instead of baseHref=./
splincode
approved these changes
Aug 14, 2024
nsbarsukov
changed the title
baseHref=/ instead of baseHref=./baseHref=/ instead of baseHref=./
nsbarsukov
requested review from
waterplea,
MarsiBarsi and
vladimirpotekhin
as code owners
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.