chore(demo): use baseHref=/ instead of baseHref=./ (#8526)

taiga-family · Aug 14, 2024 · 9ad873b · 9ad873b
1 parent fb150f8
commit 9ad873b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 11 deletions.
diff --git a/.github/workflows/deploy-preview.yml b/.github/workflows/deploy-preview.yml
@@ -10,7 +10,7 @@ jobs:
       - uses: taiga-family/ci/actions/setup/[email protected]
       - uses: taiga-family/ci/actions/setup/[email protected]
       - uses: taiga-family/ci/actions/setup/[email protected]
-      - run: npx nx build demo --base-href='/'
+      - run: npx nx build demo
       - name: Debug output
         run: tree dist/demo/browser -P '*.html'
       - name: Deploy preview

diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -22,7 +22,7 @@ jobs:
       - uses: taiga-family/ci/actions/setup/[email protected]
 
       - name: Building demo-app of git-branch without cache
-        run: npx nx build demo -c next --output-path ${{ env.DIST }} --base-href='/'
+        run: npx nx build demo -c next --output-path ${{ env.DIST }}
 
       - name: Upload cache / ${{ env.CACHE_DIST_KEY }}
         uses: actions/cache/[email protected]
@@ -129,6 +129,7 @@ jobs:
                 --branch snapshots/demo/next/${{ github.base_ref }} \
                 https://github.com/taiga-family/taiga-ui.git ${{ env.DIST_NEXT }}
 
+      # TODO: delete this step after merging of https://github.com/taiga-family/taiga-ui/pull/8526 (after snapshot update)
       - name: Find and replace baseHref for next snapshot
         uses: jacobtomlinson/gha-find-replace@v3
         with:

diff --git a/projects/demo/project.json b/projects/demo/project.json
@@ -44,7 +44,7 @@
                         "output": "assets/taiga-ui/icons"
                     }
                 ],
-                "baseHref": "./",
+                "baseHref": "/",
                 "styles": [
                     "{projectRoot}/src/normalize.less",
                     "{projectRoot}/src/styles.less",
@@ -91,11 +91,8 @@
                     "statsJson": false,
                     "progress": false
                 },
-                "development": {
-                    "baseHref": "/"
-                },
+                "development": {},
                 "def": {
-                    "baseHref": "/",
                     "fileReplacements": [
                         {
                             "replace": "{projectRoot}/src/emulate/change-detection-strategy.ts",
@@ -104,7 +101,6 @@
                     ]
                 },
                 "shadow": {
-                    "baseHref": "/",
                     "fileReplacements": [
                         {
                             "replace": "{projectRoot}/src/emulate/view-encapsulation.ts",
@@ -113,13 +109,11 @@
                     ]
                 },
                 "fast": {
-                    "baseHref": "/",
                     "sourceMap": false,
                     "namedChunks": false,
                     "statsJson": false
                 },
                 "coalescing": {
-                    "baseHref": "/",
                     "fileReplacements": [
                         {
                             "replace": "{projectRoot}/src/emulate/ng-zone-options.ts",

diff --git a/projects/demo/src/modules/app/app.providers.ts b/projects/demo/src/modules/app/app.providers.ts
@@ -60,7 +60,8 @@ export const APP_PROVIDERS: Provider[] = [
     {
         provide: APP_BASE_HREF,
         // @note: By default, on webcontainer.io will not be provided APP_BASE_HREF, we use fallback
-        useFactory: () => inject(DOCUMENT).querySelector('base')?.href || '/',
+        useFactory: () =>
+            inject(DOCUMENT).querySelector('base')?.getAttribute('href') || '/',
     },
     {
         provide: TUI_IS_PLAYWRIGHT,