Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): reuse cursor position after showing password #8188

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix(kit): reuse cursor position after showing password #8188

merged 1 commit into from
Aug 1, 2024

Conversation

splincode
Copy link
Member

Closes #7281

@splincode splincode added the v3 label Jul 24, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 24, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8bcea2e):

https://taiga-ui--pr8188-splincode-fix-passwo-aec33qo8.web.app

(expires Thu, 01 Aug 2024 13:46:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Jul 24, 2024 •
edited
Loading

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +392.8KB +10%
✅ demo/browser/vendor.(hash).js
 +214.57KB +10%
✅ demo/browser/runtime.(hash).js
 +41.38KB +10%
✅ demo/browser/polyfills.(hash).js
 +15.22KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +665.37KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.41MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@splincode splincode force-pushed the splincode/fix-password branch from 417cce3 to 95e0275 Compare July 31, 2024 13:41
@splincode splincode force-pushed the splincode/fix-password branch from 95e0275 to 8bcea2e Compare July 31, 2024 13:41
@splincode splincode requested a review from nsbarsukov July 31, 2024 13:41
@splincode splincode merged commit 864e50e into v3.x Aug 1, 2024
31 of 32 checks passed
@splincode splincode deleted the splincode/fix-password branch August 1, 2024 08:17
@splincode splincode linked an issue Aug 1, 2024 that may be closed by this pull request
🐞 - Caret in InputPassoword works instable while clicking show/hide password button #7281
Closed
9 tasks
@taiga-family-bot taiga-family-bot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

Assignees

@splincode splincode

Labels
v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Caret in InputPassoword works instable while clicking show/hide password button
3 participants
@splincode @waterplea @nsbarsukov