Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 - Caret in InputPassoword works instable while clicking show/hide password button #7281

Closed
2 of 9 tasks
viktorzdanovich opened this issue Apr 22, 2024 · 4 comments · Fixed by #8188 or #8291
Closed
2 of 9 tasks

🐞 - Caret in InputPassoword works instable while clicking show/hide password button #7281

viktorzdanovich opened this issue Apr 22, 2024 · 4 comments · Fixed by #8188 or #8291
Assignees
@splincode
Labels
P3 This issue has low priority

Comments

@viktorzdanovich
Copy link

Playground Link

No response

Description

When starting randomly hitting "show" or "hide" buttons in InputPassword component, the caret can change its position to the beginning of the field though initially it was set to other place.

The behavior can be reproduced on https://taiga-ui.dev/.

See attachment
Kapture 2024-04-22 at 11 42 01

Angular version

17.1.0

Taiga UI version

3.68.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@ankiitkumar07
Copy link

Hi @viktorzdanovich
let me know if I can work on this.

@splincode
Copy link
Member

@viktorzdanovich sure, go ahead

@splincode splincode added contributions welcome Architecture is clear and community can help P3 This issue has low priority and removed state: need triage labels Apr 23, 2024
@al-march al-march mentioned this issue May 1, 2024
Closed
@viktorzdanovich
Copy link
Author

@splincode is there any updates on this issue?

@splincode
Copy link
Member

@viktorzdanovich
#7343 (review)

@splincode splincode mentioned this issue Jul 24, 2024
Merged
@splincode splincode self-assigned this Jul 24, 2024
@splincode splincode linked a pull request Aug 1, 2024 that will close this issue
fix(kit): reuse cursor position after showing password #8188
Merged
@splincode splincode mentioned this issue Aug 1, 2024
Merged
@waterplea waterplea removed the contributions welcome Architecture is clear and community can help label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@splincode splincode

Labels
P3 This issue has low priority
Milestone
No milestone
4 participants
@waterplea @splincode @viktorzdanovich @ankiitkumar07