Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputFiles fix drag over detection when zone.js event coalescing is enabled #7031

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

hakimio
Copy link
Contributor

@hakimio hakimio commented Mar 19, 2024

Closes #7004

Copy link

lumberjack-bot bot commented Mar 19, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Mar 19, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+388.01KB +10%
demo/browser/vendor.(hash).js
+214.22KB +10%
demo/browser/runtime.(hash).js
+41.05KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +655.92KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.38MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v3.x@c783dab). Click here to learn what that means.

Files Patch % Lines
...it/components/input-files/input-files.component.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #7031   +/-   ##
=======================================
  Coverage        ?   70.46%           
=======================================
  Files           ?     1097           
  Lines           ?    13118           
  Branches        ?     1860           
=======================================
  Hits            ?     9244           
  Misses          ?     3561           
  Partials        ?      313           
Flag Coverage Δ
addon-charts 71.52% <ø> (?)
addon-doc 60.58% <ø> (?)
addon-mobile 60.50% <ø> (?)
addon-table 60.50% <ø> (?)
addon-tablebars 96.15% <ø> (?)
cdk ∅ <ø> (?)
core 77.60% <ø> (?)
kit 70.22% <0.00%> (?)
summary 70.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit 5b9a605 into taiga-family:v3.x Mar 19, 2024
31 of 32 checks passed
@hakimio
Copy link
Contributor Author

hakimio commented Mar 19, 2024

@splincode thanks for merging the PR.
RoutableDialog: should work after switching tabs e2e test failure seems to be related to zone.js event coalescing. Might want to check that.

This was referenced Mar 19, 2024
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants