Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 - File input "drag over" stops working when zone.js eventCoalescing is enabled #7004

Closed
2 of 9 tasks
hakimio opened this issue Mar 14, 2024 · 3 comments
Closed
2 of 9 tasks
Assignees
Labels
community contribution This issue was closed by a PR from the community P2 This issue has medium priority S2 This issue has medium severity

Comments

@hakimio
Copy link
Contributor

hakimio commented Mar 14, 2024

Playground Link

No response

Description

  • Enable zone.js enventCoalescing:
    Standalone apps:
export const appConfig: ApplicationConfig = {
  providers: [
    provideZoneChangeDetection({
      eventCoalescing: true
    })
  ]
};

NgModule based apps:

platformBrowserDynamic()
  .bootstrapModule(AppModule, { ngZoneEventCoalescing: true })
  .catch(err => console.error(err));
  • Try to drag files over Taiga file input.
  • The file input style doesn't change

Angular folks say it's not an issue on their end: angular/angular#54856
Can be reproduced on Chrome, but not on Firefox.

Angular version

17.3.0

Taiga UI version

3.70.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@waterplea
Copy link
Collaborator

Looks like we can be storing dataTransfer.files instead of the entire DataTransfer object. Should be an easy fix, would you like to contribute a PR? For both v3.x and main, file structure has changed a bit.

@hakimio
Copy link
Contributor Author

hakimio commented Mar 19, 2024

Ok, I can try to fix this.

@waterplea waterplea added contributions welcome Architecture is clear and community can help P2 This issue has medium priority S2 This issue has medium severity and removed state: need triage labels Mar 19, 2024
@hakimio
Copy link
Contributor Author

hakimio commented Mar 19, 2024

v4 seems uneffected by the bug:


I have opened a PR for v3: #7031

@waterplea waterplea added community contribution This issue was closed by a PR from the community and removed contributions welcome Architecture is clear and community can help labels Mar 20, 2024
@github-project-automation github-project-automation bot moved this from 💡 Backlog to ✅ Done in Taiga-family Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community P2 This issue has medium priority S2 This issue has medium severity
Development

No branches or pull requests

2 participants