Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(phone): add ability to configure the separator #685

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #680

What is the new behaviour?

added new parameter separator with default value -

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 2e72efc):

https://maskito--pr685-phone-separator-0yxha89a.web.app

(expires Thu, 23 Nov 2023 11:41:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 61e4dea776cbea516b68c67840913d2edd88bb90

@github-actions github-actions bot added the ready to merge ready label Nov 22, 2023
@splincode splincode merged commit ab6bb11 into main Nov 22, 2023
25 checks passed
@splincode splincode deleted the phone-separator branch November 22, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why the last part of any phone number is joined with a - ?
3 participants