Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Release/v1.9.0 #691

Merged
merged 1 commit into from
Nov 23, 2023
Merged

🚀 Release/v1.9.0 #691

merged 1 commit into from
Nov 23, 2023

Conversation

taiga-family-bot
Copy link
Contributor

1.9.0 (2023-11-23)

Features

  • phone: add ability to configure the separator (#685)
    (ab6bb11)

DO NOT SQUASH OR REBASE ME

if user merges this PR via rebasing or using squash, it will cause lost of the tag. It happens because tag is already
attached to the initial release commit SHA. If we use rebase or squash, the commit sha changes and already created tag
points to not-existing commit.

@taiga-family-bot taiga-family-bot self-assigned this Nov 23, 2023
github-actions[bot]
github-actions bot approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Automated approved)

taiga-family-approve-bot
taiga-family-approve-bot approved these changes Nov 23, 2023
View reviewed changes
Copy link

@taiga-family-approve-bot taiga-family-approve-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Automated approved)

@github-actions github-actions bot added the ready to merge ready label Nov 23, 2023
@nsbarsukov nsbarsukov merged commit de3493a into main Nov 23, 2023
22 checks passed
@nsbarsukov nsbarsukov deleted the release/1.9.0 branch November 23, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiga-family-approve-bot taiga-family-approve-bot taiga-family-approve-bot approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@taiga-family-bot taiga-family-bot

Labels
ready to merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taiga-family-bot @taiga-family-approve-bot @nsbarsukov