feat!: complete client verification #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blckngm
force-pushed
the
complete-client
branch
from
8c8d5ee to
5f410da
Compare
blckngm
force-pushed
the
complete-client
branch
from
64d3ebd to
4ce89c4
Compare
blckngm
force-pushed
the
complete-client
branch
from
098fa3c to
d6ce7bb
Compare
blckngm
force-pushed
the
complete-client
branch
from
d6ce7bb to
877928a
Compare
Don't check client id in handler, check it when loading the client
Flouse
pushed a commit
that referenced
this pull request
Nov 21, 2023
Co-authored-by: liyukun <[email protected]> These checks are also covered in #20 as: ``` if old.state != State::Open { return Err(VerifyError::WrongChannelState); } if !old_args.open { return Err(VerifyError::WrongChannelArgs); } old.state = State::Closed; old_args.open = false; if old != new { return Err(VerifyError::WrongChannel); } if old_args != new_args { return Err(VerifyError::WrongChannelArgs); } ```
blckngm
changed the title
ashuralyk
approved these changes
Nov 28, 2023
Comment on lines
-462
to
549
| if !old_args.open | ||
| || new_args.open | ||
| || old_args.client_id != new_args.client_id | ||
| || old_args.channel_id != new_args.channel_id | ||
| || old_args.port_id != new_args.port_id | ||
| { | ||
| if !old_args.open { | ||
| return Err(VerifyError::WrongChannelArgs); | ||
| } |
There was a problem hiding this comment.
the reason of deleting these checks is the following light client check has already covered them in an alternative way?
There was a problem hiding this comment.
These kind of checks are replaced by “mutate and compare equal” checks, see the following lines.
jjyr
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.