fix: channel close check not enough (#22)

Co-authored-by: liyukun <[email protected]> These checks are also covered in #20 as: ``` if old.state != State::Open { return Err(VerifyError::WrongChannelState); } if !old_args.open { return Err(VerifyError::WrongChannelArgs); } old.state = State::Closed; old_args.open = false; if old != new { return Err(VerifyError::WrongChannel); } if old_args != new_args { return Err(VerifyError::WrongChannelArgs); } ```
synapseweb3 · Nov 21, 2023 · 622cecd · 622cecd
1 parent 0299a91
commit 622cecd
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/axon/src/handler/mod.rs b/axon/src/handler/mod.rs
@@ -434,7 +434,12 @@ pub fn handle_msg_channel_close_init<C: Client>(
     if old.state != State::Open || new.state != State::Closed {
         return Err(VerifyError::WrongChannelState);
     }
-    if !old_args.open || new_args.open {
+    if !old_args.open
+        || new_args.open
+        || old_args.client_id != new_args.client_id
+        || old_args.channel_id != new_args.channel_id
+        || old_args.port_id != new_args.port_id
+    {
         return Err(VerifyError::WrongChannelArgs);
     }
     Ok(())
@@ -454,7 +459,12 @@ pub fn handle_msg_channel_close_confirm<C: Client>(
     if old.state != State::Open || new.state != State::Closed {
         return Err(VerifyError::WrongChannelState);
     }
-    if !old_args.open || new_args.open {
+    if !old_args.open
+        || new_args.open
+        || old_args.client_id != new_args.client_id
+        || old_args.channel_id != new_args.channel_id
+        || old_args.port_id != new_args.port_id
+    {
         return Err(VerifyError::WrongChannelArgs);
     }