Remove the requirement for 3 touch points #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavidMerzJr @marip8 ping |
marip8
requested changes
Feb 14, 2020
|
I created an issue (#18) to discuss the fate of these features, but I think this is a good stop-gap measure for users who don't want/need to create the points |
mpowelson
force-pushed
the
feature/remove_min_touchpoints
branch
from
d4f7c2a to
8b35a92
Compare
marip8
approved these changes
Feb 14, 2020
|
@marip8 Who has authority to merge? I don't seem to. This one is long overdue for this simple fix. |
|
It appears CI is failing because of a clang formatting issue. I'll update and merge today |
|
@marip8 If you have permissions on this repo, please accept this PR. Also please give me permissions. I have several PR's between myself and Collin that we'd like to review and approve. |
marip8
force-pushed
the
feature/remove_min_touchpoints
branch
from
c7eef51 to
7f5a6ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the ultimate plan is for this (or any) feature. However, until the master plan for what this thing is supposed to look like is released, I'm proposing we remove the requirement to have 3 touch points.