Sync in changes made to cmark-gfm after 2021-08-01 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with oss-fuzz first.
Python 3.8 has removed the cgi.escape function, which had been deprecated since version 3.2. html.escape does the same thing, use that instead. Signed-off-by: Keith Packard <[email protected]>
When two footnote references are adjacent, the handle_close_bracket function will first try to match the closing bracket to a link reference. Now we reset the subject's state, so that the parser correctly picks up both footnote references.
…ark_nodes. Sometimes, the autolinker will go ahead and greedily split input into multiple text nodes in the hopes of matching a hyperlink. This broke footnotes, which expected a singular node. Instead of relying on the tokenizing to have worked perfectly, when handling footnote references we now simply insert the reference based on the closing bracket and ignore and delete any existing and superfluous nodes.
When a footnote is referenced multiple times, we now insert multiple backrefs linking back to each reference. In order to do this, we had to change how footnote ref link labels work away from an incrementing index, and instead use footnote reference label text *plus* an index.
…in multiple places and multiple backrefs.
…ontain 'w' or '_'.
Move CI build over to Actions, per `@jgm`'s upstream work.
… intent more obvious.
…ade sure to free allocated string in commonmark.c
Add data attributes for easier styling within dotcom. Also, add the aria-label for accessibility.
…nkrefs-autolinker Fix footnotes: nested, confused for link refs & mangled by the autolinker
…fnref-label-and-backrefs Fix footnotes plus fix footnote reference labels and backrefs
…otes Add data attributes for footnotes
Bump version to `0.29.0.gfm.2`
This was referenced Dec 29, 2021
* added explicit check for UINT16_MAX boundary on row->n_columns * added additional checks for row_from_string NULL returns to prevent NULL dereferences on error cases * added additional check to ensure n_columns between marker and header rows always match prior to any alignment processing * allocate alignment array based on marker rows rather than header rows * prevent memory leak on dangling node when encountering row_from_string error in try_opening_table_row * add explicit integer overflow error marker to not overload offset semantics in row_from_string with other implied error conditions
0.29.0.gfm.3 patch
QuietMisdreavus
force-pushed
the
QuietMisdreavus/sync-upstream
branch
from
4c40013 to
2cd664e
Compare
|
I've updated this PR to include the changes from GHSA-mc3g-88wq-6f4x (effectively just the version number bump and the commit history, because the patch itself was merged in #36), bringing this up to date with the current |
| compiler: | ||
| - c: 'clang' | ||
| cpp: 'clang++' | ||
| - c: 'gcc' |
There was a problem hiding this comment.
If gcc is available on macOS in GitHub Actions (i assume so since this is an upstream change), i guess they want to make sure to test it. However, this doesn't affect our fork, since we don't use GitHub Actions.
QuietMisdreavus
force-pushed
the
QuietMisdreavus/sync-upstream
branch
from
2cd664e to
131078b
Compare
|
I rebased this PR to include new changes on |
daniel-grumberg
approved these changes
Mar 11, 2022
|
Yeah, it's all upstream. The only change on top of that is to update the readme to remove the GitHub Actions badge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In August and September, GitHub made various updates to cmark-gfm to re-enable footnotes. This PR pulls in the upsream changes to the
gfmbranch so that we can have those fixes in Swift-DocC as well.There were also updates to the testing scripts and an additional configuration for GitHub Actions. The latter doesn't affect this repo since we don't use GitHub Actions.
I've tested these changes by manually loading them into swift-markdown and swift-docc and ensuring that the tests pass. Note that the local test suite doesn't completely pass due to changes we made to support inline attributes. A fix for that will come in a later PR (which will also help #28).