allow extensions to use ! and ^ as special characters
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I split off a change from #28 into this branch so that |
QuietMisdreavus
force-pushed
the
QuietMisdreavus/sync-upstream
branch
from
4c40013 to
2cd664e
Compare
QuietMisdreavus
force-pushed
the
QuietMisdreavus/extended-ext
branch
from
1e705e9 to
46bda92
Compare
|
I've rebased this PR atop the new updates in #29. |
QuietMisdreavus
force-pushed
the
QuietMisdreavus/sync-upstream
branch
from
2cd664e to
131078b
Compare
| } | ||
| break; | ||
| default: |
There was a problem hiding this comment.
What happenned to the default case? Did you just push it outside the switch?
There was a problem hiding this comment.
Yes. I had to move the try_extensions call outside of this switch, so that it could be tried with characters that are part of the built-in grammar (specifically ^ and [). That's also why i modified the ! and ^ branches to peek for their syntax instead of eagerly advancing the pointer.
QuietMisdreavus
force-pushed
the
QuietMisdreavus/extended-ext
branch
from
46bda92 to
05a5f22
Compare
| @@ -1563,43 +1564,49 @@ static int parse_inline(cmark_parser *parser, subject *subj, cmark_node *parent, | |||
| new_inl = handle_close_bracket(parser, subj); | |||
| break; | |||
| case '!': | |||
| advance(subj); | |||
| if (peek_char(subj) == '[' && peek_char_n(subj, 1) != '^') { | |||
| if (peek_char_n(subj, 1) == '[' && peek_char_n(subj, 2) != '^') { | |||
There was a problem hiding this comment.
Maybe add a comment saying that this case is not effectively "
daniel-grumberg
approved these changes
Mar 11, 2022
- generalize the special-character-inline-creating section - add comments about looking for images and attributes specificall
QuietMisdreavus
force-pushed
the
QuietMisdreavus/extended-ext
branch
from
d9b0520 to
76ae837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing updates for #28, and while verifying changes for #29, i noticed that some special characters weren't being handled properly, and couldn't be used by extensions. This updates the
parse_inlinefunction to allow^and!to be used as special characters by extensions. This also allows footnotes to work with our implementation of inline attributes, allowing the full test suite to pass.