Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing an issue with the API end point in the extension package of gemini + a little README typo #106

Conversation

Muhammad-saad-2000
Copy link
Contributor

Hello again @svilupp,

Following-up to my previous pull request regarding the Gemini issue. If you decided to integrate GoogleGenAI.jl package, there's a minor missing part in end point that is used in GoogleGenAIPromptingToolsExt.jl.

Also, there is a little README typo that is corrected as well (could have made it in a another pull request but thought that this very minor).

@Muhammad-saad-2000 Muhammad-saad-2000 changed the title Fixing an issue with the API end point in the extension package of Gemini + a little README typo Fixing an issue with the API end point in the extension package of gemini + a little README typo Mar 21, 2024
@svilupp
Copy link
Owner

svilupp commented Mar 22, 2024

Thank you for the PR. Would you mind separating the README typo please? I would accept that fix right away.

As for the GoogleGenAI, that was a light interface over old version of Tyler’s package. I suspect that it won’t be needed with the version he just requested for registering - we need to check what changes are required when the package is registered.

You can have a look if we need this function (by running PT + GoogleGenAI in its current form).
Also, some of my past requests were captured here: tylerjthomas9/GoogleGenAI.jl#2
There will be a need to have a look at what’s new and if we need to change how we interface with it.

@Muhammad-saad-2000
Copy link
Contributor Author

I will wait for the registered version and see what should be done 👍🏼

@svilupp
Copy link
Owner

svilupp commented Mar 26, 2024

Similarly to the other PR, I'd suggest closing this as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants