Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little README.md correction #107

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

Muhammad-saad-2000
Copy link
Contributor

The aforementioned correction in #106

@svilupp
Copy link
Owner

svilupp commented Mar 24, 2024

Hi Muhammad! thank you for the PR!

Apologies for not engaging with it sooner. I thought there was some typo in the README, but the correction you're suggesting is not necessary I believe.

Have you tried using Pkg; Pkg.add("PromptingTools") ? Did it not work for you? Because it does work for me.

Julia packages are often referred to with the .jl suffix, but you don't have to use it when referring to them / importing them / adding them.

Or is your experience different?

@svilupp
Copy link
Owner

svilupp commented Mar 24, 2024

As an example, your correction would actually lead to an error:

julia> Pkg.add("PromptingTools.jl")
ERROR: `PromptingTools.jl` is not a valid package name. Perhaps you meant `PromptingTools`

@Muhammad-saad-2000
Copy link
Contributor Author

Hello, it is my pleasure to contribute to this repository.

I believe there is a miss understanding regarding my pull request. The current state of the README mentions Pkg.add("PromptingTools.jl") not Pkg.add("PromptingTools"), and that is what my PR is correcting.

You can double check that from the current README.md (the main page).

@svilupp
Copy link
Owner

svilupp commented Mar 24, 2024

Ha! good catch - thank you!

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (feb03ed) to head (21c2fc7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   93.07%   93.01%   -0.07%     
==========================================
  Files          39       39              
  Lines        2772     2776       +4     
==========================================
+ Hits         2580     2582       +2     
- Misses        192      194       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svilupp svilupp merged commit 34ed7d5 into svilupp:main Mar 24, 2024
4 of 5 checks passed
svilupp pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants