Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect when the extension button is clicked #299

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

redirect when the extension button is clicked #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c51daa
Update manifest.json
MarkAppprogrammer Sep 26, 2024
d850eac
Create home.html
MarkAppprogrammer Sep 26, 2024
ab96eb2
Update manifest.json
MarkAppprogrammer Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/extension/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<html>
<head></head>
<body></body>
<script>
chrome.tabs.update({
url: "https://supermemory.ai/home"
});
</script>
</html>
10 changes: 8 additions & 2 deletions apps/extension/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,16 @@
},
"web_accessible_resources": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: Excessive permissions in manifest.json

Solution: Restrict 'host_permissions' to only the necessary URLs.

Suggested change
"web_accessible_resources": [
"host_permissions":["https://specific-domain.com/*"]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing code allows for ["<all_urls>"] not limited to a specific domain.

{
"resources": ["public/*"],
"resources": [
"public/*",
"content/*"
],
"matches": ["<all_urls>"]
}
],
"permissions": ["webRequest", "storage", "contextMenus"],
"host_permissions": ["<all_urls>"]
"host_permissions": ["<all_urls>"],
"action": {
"default_popup": "home.html"
}
}