-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redirect when the extension button is clicked #299
base: main
Are you sure you want to change the base?
Conversation
added html page
added action
The code for host permissions was the same as before (refer to line 27 of the previous version) |
Hi! Thank you so much for this!!! This works great, but I found an unrelated issue that we can just add to this PR. Open chrome console on any website ->
this resource is blocked because of web_accessible_resource policy |
fixed the #supermemory-extension-host and added curly brackets for "action"
🔍 Code Review Summary❗ Attention Required: This push has potential issues. 🚨 Overview
🚨 Critical Issuessecurity (1 issues)1. Excessive permissions in manifest.json📁 File: apps/extension/manifest.json 💡 Solution: Current Code: "host_permissions":["<all_urls>"] Suggested Code: "host_permissions":["https://specific-domain.com/*"]
Useful Commands
|
@@ -19,10 +19,16 @@ | |||
}, | |||
"web_accessible_resources": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment: Excessive permissions in manifest.json
Solution: Restrict 'host_permissions' to only the necessary URLs.
"web_accessible_resources": [ | |
"host_permissions":["https://specific-domain.com/*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing code allows for ["<all_urls>"]
not limited to a specific domain.
@Dhravya Are we still going to close this PR? |
Extension Manifest Update
Update the Chrome extension manifest to include new functionality.
home.html
file to handle extension popup behaviorweb_accessible_resources
to includecontent/*
filesaction
configuration to set the default popup for the extensionThe extension will now open the SuperMemory.ai home page when the user clicks the extension icon, providing a more seamless user experience.
Original Description
# Update Chrome Extension Manifest**
Update the Chrome extension manifest to include a default popup page.
home.html
file that redirects the user to thehttps://supermemory.ai/home
URL.manifest.json
file to include anaction
section with adefault_popup
property pointing to thehome.html
file.webRequest
,storage
, andcontextMenus
APIs, as well as all URLs.**
This change will provide users with a default popup page when they click on the extension icon, which will redirect them to the SuperMemory.ai home page. This can improve the user experience and discoverability of the extension's functionality.
Original Description
A simple redirect when the extension button is clicked to make it easier to access the home page and to ask supermemory