[v5] Actor status object #4199
[v5] Actor status object #4199
Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 27806d6:
|
|
@Andarist Need help with the types 🥺 |
packages/core/src/StateMachine.ts
Outdated
| @@ -377,10 +377,10 @@ export class StateMachine< | |||
| state: State<TContext, TEvent, TActor, TOutput, TResolvedTypesMeta> | |||
| ) { | |||
| return state.error | |||
| ? { status: 'error', data: state.error } | |||
| ? { status: 'error' as const, data: state.error } | |||
There was a problem hiding this comment.
As done in other PR, we could rename this here: data -> error
| input: undefined, | ||
| data: (event as any).data, // TODO: if we keep this as `data` we should reflect this in the type | ||
| output: (event as any).data, // TODO: if we keep this as `data` we should reflect this in the type |
There was a problem hiding this comment.
after the change we'll be able to drop this comment
packages/core/src/interpreter.ts
Outdated
There was a problem hiding this comment.
It would be cool to remove ActorStatus from here? piggy-back on the getStatus or smth like that?
# Conflicts: # packages/core/src/actors/index.ts # packages/core/src/interpreter.ts
| @@ -64,14 +67,15 @@ export function fromObservable<T, TInput>( | |||
| }); | |||
| return { | |||
| ...state, | |||
| data: (event as any).data | |||
| output: (event as any).data | |||
There was a problem hiding this comment.
note: this is a mistake - nextEventType shouldn't assign to output. I'm working on this branch locally so I'll fix this.
No description provided.