[v5] onSnapshot for all actors
#4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c54f8f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c54f8f8:
|
|
@Andarist I need help because the test failures are only related to |
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Aug 24, 2023
Andarist
reviewed
Sep 25, 2023
Andarist
reviewed
Sep 25, 2023
Co-authored-by: Mateusz Burzyński <[email protected]>
Co-authored-by: Mateusz Burzyński <[email protected]>
Andarist
reviewed
Sep 25, 2023
| const ref = spawn(observableLogic, { id: 'int' }); | ||
| const ref = spawn(observableLogic, { | ||
| id: 'int', | ||
| syncSnapshot: true |
There was a problem hiding this comment.
It's worth noting that we don't have any means right now to validate that this is actually safe on the type-level
Andarist
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
onSnapshot: { ... }support for all supported invoked actor logic.