Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Fix slugify when using hyphens surrounded by spaces. #8923

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[4.x] Fix slugify when using hyphens surrounded by spaces. #8923

merged 1 commit into from
Nov 3, 2023

Conversation

duncanmcclean
Copy link
Member

This pull request fixes a small issue with the slugify function:

  • If you enter Block - Hero as a title
  • slugify would generate block_-_hero as the slug
  • With this fix, slugify will generate block_hero as the slug

Fixes #8749.

@duncanmcclean duncanmcclean changed the title Fix slugify when using hyphens surrounded by spaces. [4.x] Fix slugify when using hyphens surrounded by spaces. Nov 3, 2023
@jasonvarga jasonvarga merged commit 09ce7d4 into 4.x Nov 3, 2023
35 checks passed
@jasonvarga jasonvarga deleted the fix/slugify-method-with-hiphens branch November 3, 2023 14:43
@duncanmcclean duncanmcclean mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create fieldset/collection/taxonomy/etc handle generation does not remove hyphens surrounded by spaces
2 participants
@duncanmcclean @jasonvarga