-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to generate slug with Chinese characters #2817
Comments
I think this issue is related to pid/speakingurl#61, an issue on The update the maintainer suggests on there is for |
Doesn't look like we can use Limax as it's intended to be used server side (Node) and has a huge package load size if attempting to run client-side. I couldn't get it to compile. If we want to support Chinese and other multibyte characters, we'll need to find a compact library that can handle it. |
Any news on this. Also affects taxonomy terms. |
What if we replaced https://github.com/pid/speakingurl with a javascript helper that hits a server-side endpoint so we can use the same logic on both client/server and not worry about js package loads. 🤔 @jasonvarga whatcha think? |
That's what I was thinking too. At least for the more important language based ones like entry slugs. For stuff like field handles maybe it's less important. |
It doesn't look like I linked it to the PR but that edge case has since been fixed in the current slug implementation (see #8923). It'll also be fixed when we merge #9440 since Laravel's |
This has been fixed in Statamic 5, which we're hoping to release in the next few days/weeks. |
Bug Description
If you try to add Chinese characters in the Title field of an entry, Statamic doesn't generate the slug.
How to Reproduce
Statamic version: 3.0.25
PHP version: 7.4.8
Install method (choose one):
statamic/statamic
The text was updated successfully, but these errors were encountered: