Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Add config to (re-)enable front end route binding and support binding by field #8853

Merged
merged 20 commits into from
Oct 18, 2023
Merged

[4.x] Add config to (re-)enable front end route binding and support binding by field #8853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
bf7b318
Add config to (re-)enable front end route binding
ryanmitchell Oct 16, 2023
71f0494
Fix test failures
ryanmitchell Oct 16, 2023
2cebba9
Default to false to match current behaviour
ryanmitchell Oct 16, 2023
deffb0f
Bug fix
ryanmitchell Oct 16, 2023
faed1b6
Not sure if this is the best place for tests but
ryanmitchell Oct 16, 2023
e75140f
rename
jasonvarga Oct 16, 2023
9eb793f
test
jasonvarga Oct 17, 2023
d5412b0
fix globals not resolving by binding (globalset class doesnt have arr…
jasonvarga Oct 17, 2023
e49890b
fix wrong asset container binding
jasonvarga Oct 17, 2023
897c840
refactory/tidy
jasonvarga Oct 17, 2023
f3c9d24
assume there will always be a container in the route
jasonvarga Oct 17, 2023
c3e1dc5
refactor the conditions to methods. it was so hard to grok
jasonvarga Oct 17, 2023
2322e38
add tests for checking that bindings aren't done when theres no route…
jasonvarga Oct 17, 2023
912bcd1
fix
jasonvarga Oct 17, 2023
e9c4fb9
adjust config
jasonvarga Oct 17, 2023
6fc8b13
Fix
ryanmitchell Oct 18, 2023
7f8a47c
uncomment tests
jasonvarga Oct 17, 2023
544d697
fix them (except the api ones)
jasonvarga Oct 17, 2023
675997f
adjust api revision tests
jasonvarga Oct 18, 2023
da41d82
dont bind revisions in api
jasonvarga Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions config/routes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,19 @@

'enabled' => true,

/*
|--------------------------------------------------------------------------
| Enable Route Bindings
|--------------------------------------------------------------------------
|
| Whether route bindings for Statamic repositories (entry, taxonomy,
| collections, etc) are enabled for front end routes. This may be
| useful if you want to make your own custom routes with them.
|
*/

'bindings' => false,

/*
|--------------------------------------------------------------------------
| Action Route Prefix
Expand Down
Loading
Loading