-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x] Add config to (re-)enable front end route binding and support binding by field #8853
Merged
jasonvarga
merged 20 commits into
statamic:4.x
from
ryanmitchell:feature/front-end-route-binding
Oct 18, 2023
Merged
[4.x] Add config to (re-)enable front end route binding and support binding by field #8853
jasonvarga
merged 20 commits into
statamic:4.x
from
ryanmitchell:feature/front-end-route-binding
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmitchell
changed the title
Add config to (re-)enable front end route binding and support binding by field
[4.x] Add config to (re-)enable front end route binding and support binding by field
Oct 16, 2023
Don't think this is right. |
Yeah should have been on the ideas repo. thanks. |
…ay access so use methods)
…, ie for broadcasting
I wanted to add test coverage to this and it kinda snowballed. 😅 Lots of combinations of stuff. I wanted to make sure we don't end up screwing something up in here in the future. I'm sure I've missed something though. |
It definitely snowballed 😀 |
jasonvarga
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back when front end route binding was disabled (the irony is not lost, it was my request) to prevent conflicts with other packages. In hindsight, maybe this should have been a config, as it can be useful to have this on the front end.
This PR adds a
statamic.routes.bindings => true
config to re-enable it.At the same time it also allows the field you are binding on be specified... eg:
Adds support for some of statamic/ideas#360 - You can make custom routes, but it doesn't add support for field bindings in yaml based routes.