Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blake statement #781

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Blake statement #781

merged 1 commit into from
Aug 12, 2024

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Aug 7, 2024

This change is Reviewable

@spapinistarkware spapinistarkware mentioned this pull request Aug 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (spapini/07-30-blake_air@29d254b). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             spapini/07-30-blake_air     #781   +/-   ##
==========================================================
  Coverage                           ?   93.06%           
==========================================================
  Files                              ?       89           
  Lines                              ?    11992           
  Branches                           ?    11992           
==========================================================
  Hits                               ?    11160           
  Misses                             ?      727           
  Partials                           ?      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spapinistarkware spapinistarkware force-pushed the spapini/07-30-blake_air branch from e1f8af8 to 8bd4bff Compare August 8, 2024 12:50
@spapinistarkware spapinistarkware force-pushed the spapini/08-07-blake_statement branch from 2312c08 to 59dde0f Compare August 8, 2024 12:50
Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: up to comment fix

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5, @shaharsamocha7, and @spapinistarkware)


crates/prover/src/examples/blake/air.rs line 415 at r1 (raw file):

    let all_elements = AllElements::draw(channel);

    // Interaction.trace.

Remove dot

@spapinistarkware spapinistarkware force-pushed the spapini/07-30-blake_air branch from 8bd4bff to 29d254b Compare August 11, 2024 08:19
@spapinistarkware spapinistarkware force-pushed the spapini/08-07-blake_statement branch from 59dde0f to cc2a593 Compare August 11, 2024 08:19
Copy link
Contributor Author

spapinistarkware commented Aug 12, 2024

Merge activity

@spapinistarkware spapinistarkware changed the base branch from spapini/07-30-blake_air to graphite-base/781 August 12, 2024 10:22
@spapinistarkware spapinistarkware changed the base branch from graphite-base/781 to dev August 12, 2024 10:22
@spapinistarkware spapinistarkware force-pushed the spapini/08-07-blake_statement branch from cc2a593 to 11b272a Compare August 12, 2024 10:23
@spapinistarkware spapinistarkware merged commit f354de2 into dev Aug 12, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants