-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blake statement #781
Blake statement #781
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## spapini/07-30-blake_air #781 +/- ##
==========================================================
Coverage ? 93.06%
==========================================================
Files ? 89
Lines ? 11992
Branches ? 11992
==========================================================
Hits ? 11160
Misses ? 727
Partials ? 105 ☔ View full report in Codecov by Sentry. |
e1f8af8
to
8bd4bff
Compare
2312c08
to
59dde0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5, @shaharsamocha7, and @spapinistarkware)
crates/prover/src/examples/blake/air.rs
line 415 at r1 (raw file):
let all_elements = AllElements::draw(channel); // Interaction.trace.
Remove dot
8bd4bff
to
29d254b
Compare
59dde0f
to
cc2a593
Compare
Merge activity
|
cc2a593
to
11b272a
Compare
This change is