Optimized lookup combine

[spapinistarkware]

This change is 

[spapinistarkware]

• Blake statement #781
• Blake air #773
• Blake scheduler #770
• Blake round #767
• Optimized lookup combine #765 👈
• Blake xor table #764
• Framework component #761
• Poseidon with logup #712
• Logup trace generation #711
• is_first constant column #710
• Poseidon plain proof #708
• ProverCommitmentScheme::commit_on_evals() #707
• Eval framework info #715
• Eval framework asserts #714
• Eval framework point and domain #713
• Eval framework #706
• Eval framework preperation #705
• Generalize AirExt::mask_points() #704
• Wrap mask with TreeVec #702
• Generalize component_trace() #701
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.34%. Comparing base (17591ea) to head (4351076).

Files	Patch %	Lines
crates/prover/src/constraint_framework/logup.rs	96.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #765      +/-   ##
==========================================
+ Coverage   93.27%   93.34%   +0.07%     
==========================================
  Files          89       89              
  Lines       11948    11957       +9     
  Branches    11948    11957       +9     
==========================================
+ Hits        11144    11161      +17     
+ Misses        703      695       -8     
  Partials      101      101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 2 of 9 files at r2, 7 of 7 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

---

crates/prover/src/constraint_framework/logup.rs line 118 at r4 (raw file):

    pub alpha: SecureField,
    /// Precomputed powers of alpha.
    powers: Vec<SecureField>,

Rename

Suggestion:

alpha_powers: Vec<SecureField>,

---

crates/prover/src/constraint_framework/logup.rs line 121 at r4 (raw file):

}
impl LookupElements {
    pub fn draw(channel: &mut Blake2sChannel, n_powers: usize) -> Self {

Rename

Suggestion:

n_alpha_powers: usize

---

crates/prover/src/examples/poseidon/mod.rs line 371 at r4 (raw file):

    span.exit();

    // Draw lookup element.

non-blocking

Suggestion:

   // Draw lookup elements.

[spapinistarkware]

Reviewable status: 8 of 10 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

crates/prover/src/constraint_framework/logup.rs line 118 at r4 (raw file):

Previously, shaharsamocha7 wrote…

Rename

Done.

---

crates/prover/src/constraint_framework/logup.rs line 121 at r4 (raw file):

Previously, shaharsamocha7 wrote…

Rename

This goes away next PR, and I'd ike to avoid conflicts:)

[shaharsamocha7]

Reviewed 1 of 2 files at r5.
Reviewable status: 9 of 10 files reviewed, all discussions resolved (waiting on @spapinistarkware)