Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set tx_hash as default in create declare tx for testing #780

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Sep 15, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Sep 15, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.298 ms 66.383 ms 66.480 ms]
change: [-8.7066% -5.4971% -2.6369%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (93a2b3d) to head (890f0f5).

Files with missing lines Patch % Lines
crates/starknet_api/src/test_utils/declare.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                                      Coverage Diff                                      @@
##           arni/test_utils/move_test_object_creation_macros_to_snapi     #780      +/-   ##
=============================================================================================
- Coverage                                                      75.26%   75.26%   -0.01%     
=============================================================================================
  Files                                                             88       88              
  Lines                                                          11041    11043       +2     
  Branches                                                       11041    11043       +2     
=============================================================================================
+ Hits                                                            8310     8311       +1     
- Misses                                                          2322     2323       +1     
  Partials                                                         409      409              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/test_utils/move_test_object_creation_macros_to_snapi branch from ae4ae2f to 93a2b3d Compare September 15, 2024 10:55
@ArniStarkware ArniStarkware force-pushed the arni/test_utils/declare/set_tx_hash_as_default branch from 210e0d6 to 890f0f5 Compare September 15, 2024 10:55
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.264 ms 66.534 ms 67.000 ms]
change: [-8.8761% -5.5374% -2.4905%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

@ArniStarkware
Copy link
Contributor Author

The opposite PR should be created. For invoke + deploy account the tx_hash field should be added.

@ArniStarkware ArniStarkware deleted the arni/test_utils/declare/set_tx_hash_as_default branch September 15, 2024 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant