test: move nonce storage_key and compiled_class_hash macros to starknet api test utils

[ArniStarkware]

This change is 

[ArniStarkware]

• chore: set tx_hash as default in create declare tx for testing #780
• test: move nonce storage_key and compiled_class_hash macros to starknet api test utils #760 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.956 ms 66.025 ms 66.097 ms]
change: [-7.3185% -4.0643% -1.3902%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.51%. Comparing base (8aa893b) to head (f1c4d52).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
+ Coverage   74.44%   74.51%   +0.07%     
==========================================
  Files         364      366       +2     
  Lines       38395    38587     +192     
  Branches    38395    38587     +192     
==========================================
+ Hits        28583    28754     +171     
- Misses       7493     7506      +13     
- Partials     2319     2327       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ArniStarkware]

Reviewable status: 0 of 15 files reviewed, all discussions resolved (waiting on @MohammadNassar1)

---

crates/blockifier/src/test_utils.rs line 114 at r1 (raw file):

pub const CURRENT_BLOCK_TIMESTAMP_FOR_VALIDATE: u64 = 1069200;

// TODO(Yoni, 1/1/2025): move to SN API.

Removing old todos.

Code quote:

// TODO(Yoni, 1/1/2025): move to SN API.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.397 ms 66.728 ms 67.293 ms]
change: [-8.4913% -5.0156% -1.7583%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) high mild
6 (6.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.219 ms 66.375 ms 66.569 ms]
change: [-7.7345% -4.4004% -1.6073%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.797 ms 65.900 ms 66.040 ms]
change: [-8.1273% -4.9037% -2.1824%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.773 ms 67.269 ms 68.026 ms]
change: [-9.3334% -5.3442% -1.8538%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) high mild
5 (5.00%) high severe

[Yael-Starkware]

Reviewed 8 of 15 files at r1, 1 of 3 files at r2, 6 of 6 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)