Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install starknet-sierra-compile on machine to allow compilation #581

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 25, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.727 ms 64.788 ms 64.862 ms]
change: [-9.8030% -6.4673% -3.5237%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 52.08333% with 23 lines in your changes missing coverage. Please review.

Project coverage is 76.42%. Comparing base (ed6ab6f) to head (6ef6e16).
Report is 6 commits behind head on arni/starknet_sierra_compile/error_types.

Files Patch % Lines
crates/starknet_sierra_compile/src/errors.rs 25.00% 9 Missing ⚠️
...starknet_sierra_compile/src/cairo_lang_compiler.rs 0.00% 4 Missing and 2 partials ⚠️
...arknet_sierra_compile/src/command_line_compiler.rs 75.00% 0 Missing and 6 partials ⚠️
crates/gateway/src/compilation.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           arni/starknet_sierra_compile/error_types     #581      +/-   ##
============================================================================
+ Coverage                                     76.39%   76.42%   +0.03%     
============================================================================
  Files                                           349      350       +1     
  Lines                                         36900    36944      +44     
  Branches                                      36900    36944      +44     
============================================================================
+ Hits                                          28190    28236      +46     
+ Misses                                         6384     6379       -5     
- Partials                                       2326     2329       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/starknet_sierra_compile/error_types branch from 90324db to f53c3c5 Compare August 25, 2024 11:58
@ArniStarkware ArniStarkware force-pushed the arni/starknet_sierra_compile/poc_install_on_machine branch from 3714728 to 6ef6e16 Compare August 25, 2024 11:58
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.967 ms 66.050 ms 66.151 ms]
change: [-7.1641% -3.9311% -1.1294%] (p = 0.01 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe

@ArniStarkware
Copy link
Contributor Author

Was replaced by other PRs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant