feat: use the installed starknet-sierra-compile crate to compile

[ArniStarkware]

This change is 

[ArniStarkware]

• feat: use command line compiler in gateway #466
• feat: use the installed starknet-sierra-compile crate to compile #331 👈
• chore: streamline the error types in starknet_sierra_compile crate #566 : 2 other dependent PRs (#581 , #597 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.764 ms 65.846 ms 65.943 ms]
change: [-10.563% -6.9527% -3.6497%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.780 ms 65.882 ms 65.990 ms]
change: [-9.5237% -5.8538% -2.6544%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.393 ms 66.453 ms 66.525 ms]
change: [-10.001% -6.9481% -4.2495%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

[codecov]

Codecov Report

Attention: Patch coverage is 62.96296% with 20 lines in your changes missing coverage. Please review.

Project coverage is 76.44%. Comparing base (ed6ab6f) to head (6f2bfc8).
Report is 6 commits behind head on arni/starknet_sierra_compile/error_types.

Files	Patch %	Lines
...starknet_sierra_compile/src/cairo_lang_compiler.rs	0.00%	4 Missing and 2 partials ⚠️
...arknet_sierra_compile/src/command_line_compiler.rs	82.35%	0 Missing and 6 partials ⚠️
crates/starknet_sierra_compile/src/errors.rs	50.00%	6 Missing ⚠️
crates/gateway/src/compilation.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                             Coverage Diff                              @@
##           arni/starknet_sierra_compile/error_types     #331      +/-   ##
============================================================================
+ Coverage                                     76.39%   76.44%   +0.05%     
============================================================================
  Files                                           349      350       +1     
  Lines                                         36900    36951      +51     
  Branches                                      36900    36951      +51     
============================================================================
+ Hits                                          28190    28248      +58     
+ Misses                                         6384     6375       -9     
- Partials                                       2326     2328       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.098 ms 66.176 ms 66.267 ms]
change: [-8.0072% -4.8954% -2.8319%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
3 (3.00%) high mild
3 (3.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.232 ms 66.334 ms 66.454 ms]
change: [-10.080% -7.0233% -4.3620%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe

[ArniStarkware]

Reviewable status: 0 of 8 files reviewed, all discussions resolved

a discussion (no related file):
To speed up development, we made a temporary hack.

The compiler is saved as an executable to crates/starknet_sierra_compile/executable/starknet-sierra-compile.
We run this executable to compile.

---

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.689 ms 65.759 ms 65.835 ms]
change: [-3.4353% -2.4202% -1.4457%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

[dafnamatsry]

Reviewed 4 of 4 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArniStarkware)

---

crates/gateway/src/compilation.rs line 67 at r6 (raw file):

            Ok(casm_contract_class) => Ok(casm_contract_class),
            Err(starknet_sierra_compile::errors::CompilationUtilError::UnexpectedError(error)) => {
                // TODO(Arni): Log the panic.UnexpectedPanic

Can be removed?

Code quote:

 // TODO(Arni): Log the panic.UnexpectedPanic

[ArniStarkware]

crates/gateway/src/compilation.rs line 67 at r6 (raw file):

Previously, dafnamatsry wrote…

Can be removed?

Done.

[dafnamatsry]

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.034 ms 65.116 ms 65.208 ms]
change: [-7.4237% -4.1057% -1.3154%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.715 ms 65.775 ms 65.848 ms]
change: [-8.9302% -5.6800% -2.9133%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.127 ms 65.234 ms 65.377 ms]
change: [-4.8240% -3.6564% -2.5725%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.032 ms 65.524 ms 66.354 ms]
change: [-7.6091% -4.1995% -1.1020%] (p = 0.01 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) high mild
5 (5.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.035 ms 65.128 ms 65.236 ms]
change: [-10.318% -6.7873% -3.6839%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.336 ms 65.429 ms 65.537 ms]
change: [-9.8788% -6.4097% -3.2425%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

[ArniStarkware]

This PR was replaced by other PRs: #597, #598.