Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move contract class structs to common #451

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 14, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 14, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review August 14, 2024 11:04
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 87.03704% with 21 lines in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (ce82441) to head (8945659).
Report is 15 commits behind head on arni/contract_class_refactor/remove_redundent_try_from_methods.

Files Patch % Lines
crates/common/src/contract_class.rs 92.23% 1 Missing and 7 partials ⚠️
...ates/starknet_api/src/deprecated_contract_class.rs 69.23% 1 Missing and 7 partials ⚠️
crates/blockifier/src/execution/contract_class.rs 83.87% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@                                        Coverage Diff                                         @@
##           arni/contract_class_refactor/remove_redundent_try_from_methods     #451      +/-   ##
==================================================================================================
+ Coverage                                                           76.64%   76.73%   +0.09%     
==================================================================================================
  Files                                                                 346      347       +1     
  Lines                                                               36254    36215      -39     
  Branches                                                            36254    36215      -39     
==================================================================================================
+ Hits                                                                27787    27790       +3     
+ Misses                                                               6165     6125      -40     
+ Partials                                                             2302     2300       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/try_4 branch from 6dc67ed to 8bc2e61 Compare August 14, 2024 13:04
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.840 ms 64.948 ms 65.074 ms]
change: [-7.0866% -3.8243% -1.0773%] (p = 0.01 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/try_4 branch from 8bc2e61 to 8945659 Compare August 14, 2024 13:21
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.377 ms 65.439 ms 65.508 ms]
change: [-9.0107% -5.6004% -2.6578%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reviewing this PR focus on the files contract_class.rs.

Reviewable status: 0 of 51 files reviewed, all discussions resolved (waiting on @dafnamatsry and @noaov1)

@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/remove_redundent_try_from_methods branch from 0aa4641 to 45bd013 Compare August 18, 2024 06:51
@ArniStarkware
Copy link
Contributor Author

We will not create the common crate for this project.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@ArniStarkware ArniStarkware deleted the arni/contract_class_refactor/try_4 branch October 26, 2024 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant