-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move contract class structs to common #451
chore: move contract class structs to common #451
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## arni/contract_class_refactor/remove_redundent_try_from_methods #451 +/- ##
==================================================================================================
+ Coverage 76.64% 76.73% +0.09%
==================================================================================================
Files 346 347 +1
Lines 36254 36215 -39
Branches 36254 36215 -39
==================================================================================================
+ Hits 27787 27790 +3
+ Misses 6165 6125 -40
+ Partials 2302 2300 -2 ☔ View full report in Codecov by Sentry. |
6dc67ed
to
8bc2e61
Compare
Benchmark movements: |
8bc2e61
to
8945659
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When reviewing this PR focus on the files contract_class.rs
.
Reviewable status: 0 of 51 files reviewed, all discussions resolved (waiting on @dafnamatsry and @noaov1)
0aa4641
to
45bd013
Compare
We will not create the |
This change is