Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundent try_from methods for declare transaction #434

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 13, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 13, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review August 13, 2024 14:01
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/move_sn_api_to_cairo_vm_program_into_snapi branch from c892b2b to 6a04971 Compare August 14, 2024 09:00
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/remove_redundent_try_from_methods branch from 2591105 to 07ccbdb Compare August 14, 2024 09:00
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/move_sn_api_to_cairo_vm_program_into_snapi branch from 6a04971 to 0d41708 Compare August 14, 2024 11:03
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/remove_redundent_try_from_methods branch from 07ccbdb to 0aa4641 Compare August 14, 2024 11:03
@ArniStarkware ArniStarkware changed the title chore: remove redundent try_from methods for declare transaction. There will be no need as this is the same struct chore: remove redundent try_from methods for declare transaction Aug 14, 2024
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/remove_redundent_try_from_methods branch from 0aa4641 to 45bd013 Compare August 18, 2024 06:51
@ArniStarkware ArniStarkware changed the base branch from arni/contract_class_refactor/move_sn_api_to_cairo_vm_program_into_snapi to arni/contract_class_refactor/order_pub_funcs August 18, 2024 06:51
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.967 ms 65.073 ms 65.234 ms]
change: [-7.8857% -4.5699% -1.7253%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (arni/contract_class_refactor/order_pub_funcs@85e18ed). Learn more about missing BASE report.

Additional details and impacted files
@@                               Coverage Diff                               @@
##             arni/contract_class_refactor/order_pub_funcs     #434   +/-   ##
===============================================================================
  Coverage                                                ?   76.74%           
===============================================================================
  Files                                                   ?      348           
  Lines                                                   ?    36313           
  Branches                                                ?    36313           
===============================================================================
  Hits                                                    ?    27869           
  Misses                                                  ?     6125           
  Partials                                                ?     2319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware
Copy link
Contributor Author

We continue with a different path.
We will not create a unified declare tx.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@ArniStarkware ArniStarkware deleted the arni/contract_class_refactor/remove_redundent_try_from_methods branch October 26, 2024 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant