Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_integration_tests): running end to end integration test as binary #2642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lev-starkware
Copy link
Contributor

@lev-starkware lev-starkware commented Dec 10, 2024

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.76%. Comparing base (e3165c4) to head (ca1d6a0).
Report is 819 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
- Coverage   40.10%   34.76%   -5.35%     
==========================================
  Files          26      289     +263     
  Lines        1895    33186   +31291     
  Branches     1895    33186   +31291     
==========================================
+ Hits          760    11536   +10776     
- Misses       1100    20642   +19542     
- Partials       35     1008     +973     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lev-starkware lev-starkware changed the base branch from pr/lev-starkware/lev/e2e_integration/7a6dd4a7 to main December 10, 2024 15:44
@lev-starkware lev-starkware force-pushed the pr/lev-starkware/lev/e2e_integration/b11c15b5 branch 2 times, most recently from 7f9a7e0 to 7a421f7 Compare December 10, 2024 16:13
@lev-starkware lev-starkware force-pushed the pr/lev-starkware/lev/e2e_integration/b11c15b5 branch from 7a421f7 to e3ef8da Compare December 10, 2024 18:05
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)


.github/workflows/sequencer_integration_tests.yml line 13 at r1 (raw file):

env:
  SEQUENCER_INTEGRATION_TESTS: 1

Please also delete the following function:
https://github.com/starkware-libs/sequencer/blob/main/crates/starknet_integration_tests/src/utils.rs#L253-L255

Code quote:

 SEQUENCER_INTEGRATION_TESTS: 1

@lev-starkware lev-starkware force-pushed the pr/lev-starkware/lev/e2e_integration/b11c15b5 branch from e3ef8da to ca1d6a0 Compare December 12, 2024 09:24
Copy link
Contributor Author

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


.github/workflows/sequencer_integration_tests.yml line 13 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please also delete the following function:
https://github.com/starkware-libs/sequencer/blob/main/crates/starknet_integration_tests/src/utils.rs#L253-L255

Done.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants