feat(starknet_integration_tests): end to end integration test as exec…

[lev-starkware]

…utable (not test)

commit-id:7a6dd4a7

---

Stack:

• chore(starknet_integration_tests): running end to end integration tes… #2642
• feat(starknet_integration_tests): end to end integration test as exec… #2598 ⬅
• refactor(starknet_integration_tests): moving all end_to_end_integration test functions to a module #2597

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 35.00%. Comparing base (e3165c4) to head (736d6b5).
Report is 812 commits behind head on main.

Files with missing lines	Patch %	Lines
...et_integration_tests/src/end_to_end_integration.rs	0.00%	63 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2598      +/-   ##
==========================================
- Coverage   40.10%   35.00%   -5.11%     
==========================================
  Files          26      277     +251     
  Lines        1895    32227   +30332     
  Branches     1895    32227   +30332     
==========================================
+ Hits          760    11281   +10521     
- Misses       1100    19939   +18839     
- Partials       35     1007     +972     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)

---

crates/starknet_integration_tests/src/bin/e2e_integration_test.rs line 16 at r1 (raw file):

    // Run end to end integration test.
    end_to_end_integration(tx_generator).await;
}

Great!
Could you please also change the test in tests dir to directly invoke this executable?

Suggested way:

1. Use create_shell_command to invoke the binary from within the test.
2. To get its path, check https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates and look for CARGO_BIN_EXE_.

Going through the env variable should have twofold advantages:

1. No need for messy dir traversals to find the test binary
2. The doc mentions this way also builds the binary, so no need to do that manually:Binaries are automatically built when the test is built, unless the binary has required features that are not enabled.

Code quote:

#[tokio::main]
async fn main() {
    configure_tracing();
    info!("Running integration test setup.");

    // Creates a multi-account transaction generator for integration test
    let tx_generator = create_integration_test_tx_generator();

    // Run end to end integration test.
    end_to_end_integration(tx_generator).await;
}

[lev-starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_integration_tests/src/bin/e2e_integration_test.rs line 16 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Great!
Could you please also change the test in tests dir to directly invoke this executable?

Suggested way:

1. Use create_shell_command to invoke the binary from within the test.
2. To get its path, check https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates and look for CARGO_BIN_EXE_.

Going through the env variable should have twofold advantages:

1. No need for messy dir traversals to find the test binary
2. The doc mentions this way also builds the binary, so no need to do that manually:Binaries are automatically built when the test is built, unless the binary has required features that are not enabled.

Done.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, all discussions resolved

[Itay-Tsabary-Starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)