chore(starknet_integration_tests): remove const for json rpc version #2611
Conversation
|
This change is |
Itay-Tsabary-Starkware
changed the base branch from
spr/main/81012ae2
to
main
Itay-Tsabary-Starkware
force-pushed
the
spr/main/bfb3bef3
branch
from
8f8a083 to
38088cf
Compare
Itay-Tsabary-Starkware
changed the base branch from
main
to
spr/main/81012ae2
|
Artifacts upload workflows: |
Itay-Tsabary-Starkware
force-pushed
the
spr/main/bfb3bef3
branch
from
38088cf to
f81d39c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## spr/main/81012ae2 #2611 +/- ##
======================================================
- Coverage 49.76% 35.10% -14.67%
======================================================
Files 175 276 +101
Lines 20454 32166 +11712
Branches 20454 32166 +11712
======================================================
+ Hits 10179 11291 +1112
- Misses 9788 19871 +10083
- Partials 487 1004 +517 ☔ View full report in Codecov by Sentry. |
Itay-Tsabary-Starkware
force-pushed
the
spr/main/bfb3bef3
branch
from
f81d39c to
bf1166c
Compare
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_integration_tests/src/config_utils.rs line 52 at r1 (raw file):
/// Creates a config file for the sequencer node for the end to end integration test. pub(crate) fn dump_config_file_changes( config: &SequencerNodeConfig,
Should the sub-member of this struct still have the field json_rpc_version as a member of this struct?
Code quote:
SequencerNodeConfig
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
Itay-Tsabary-Starkware
force-pushed
the
spr/main/bfb3bef3
branch
from
bf1166c to
6440271
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
crates/starknet_integration_tests/src/config_utils.rs line 52 at r1 (raw file):
Previously, ArniStarkware (Arnon Hod) wrote…
Should the sub-member of this struct still have the field
json_rpc_versionas a member of this struct?
Yes, it is used to generate the rpc messages, please see https://github.com/starkware-libs/sequencer/blob/main/crates/starknet_gateway/src/rpc_state_reader.rs#L49-L59
There was a problem hiding this comment.
Reviewable status:
Itay-Tsabary-Starkware
force-pushed
the
spr/main/bfb3bef3
branch
from
6440271 to
05c3def
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
Itay-Tsabary-Starkware
force-pushed
the
spr/main/81012ae2
branch
from
427c543 to
b12444e
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/bfb3bef3
branch
from
05c3def to
adb68c8
Compare
commit-id:640fe6f5
commit-id:69ba79bd
commit-id:81012ae2
commit-id:bfb3bef3
Itay-Tsabary-Starkware
force-pushed
the
spr/main/81012ae2
branch
from
b12444e to
f29ebe5
Compare
Itay-Tsabary-Starkware
force-pushed
the
spr/main/bfb3bef3
branch
from
adb68c8 to
2d7e21e
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status:
Itay-Tsabary-Starkware
changed the base branch from
spr/main/81012ae2
to
main
commit-id:bfb3bef3
Stack: