-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(papyrus_load_test): activate missing dependency feature #2608
Conversation
28c85c9
to
f6d2033
Compare
Artifacts upload workflows: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
===========================================
+ Coverage 40.10% 77.19% +37.08%
===========================================
Files 26 392 +366
Lines 1895 42486 +40591
Branches 1895 42486 +40591
===========================================
+ Hits 760 32796 +32036
- Misses 1100 7400 +6300
- Partials 35 2290 +2255 ☔ View full report in Codecov by Sentry. |
f6d2033
to
863c7ad
Compare
863c7ad
to
9a49901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/papyrus_load_test/Cargo.toml
line 20 at r1 (raw file):
serde = { workspace = true, features = ["derive"] } serde_json = { workspace = true, features = ["arbitrary_precision"] } starknet_api = { workspace = true, features = ["testing"] }
Can it move to dev dependencies?
Code quote:
starknet_api = { workspace = true, features = ["testing"] }
9a49901
to
bac17f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
crates/papyrus_load_test/Cargo.toml
line 20 at r1 (raw file):
Previously, ArniStarkware (Arnon Hod) wrote…
Can it move to dev dependencies?
No, it's used in a non-test place
https://github.com/starkware-libs/sequencer/blob/master/crates/papyrus_load_test/src/lib.rs#L24-L24
bac17f4
to
7878126
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
7878126
to
2566c35
Compare
commit-id:640fe6f5
2566c35
to
69c70fa
Compare
✓ Commit merged in pull request #2611 |
Stack: