Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(papyrus_load_test): activate missing dependency feature #2608

Closed
wants to merge 1 commit into from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Dec 10, 2024

@reviewable-StarkWare
Copy link

This change is Reviewable

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/6fd8e685 to main December 10, 2024 07:53
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from main to spr/main/6fd8e685 December 10, 2024 07:53
Copy link

github-actions bot commented Dec 10, 2024

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (e3165c4) to head (9a49901).
Report is 800 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2608       +/-   ##
===========================================
+ Coverage   40.10%   77.19%   +37.08%     
===========================================
  Files          26      392      +366     
  Lines        1895    42486    +40591     
  Branches     1895    42486    +40591     
===========================================
+ Hits          760    32796    +32036     
- Misses       1100     7400     +6300     
- Partials       35     2290     +2255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/6fd8e685 to main December 10, 2024 10:44
Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/papyrus_load_test/Cargo.toml line 20 at r1 (raw file):

serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true, features = ["arbitrary_precision"] }
starknet_api = { workspace = true, features = ["testing"] }

Can it move to dev dependencies?

Code quote:

starknet_api = { workspace = true, features = ["testing"] }

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


crates/papyrus_load_test/Cargo.toml line 20 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Can it move to dev dependencies?

No, it's used in a non-test place
https://github.com/starkware-libs/sequencer/blob/master/crates/papyrus_load_test/src/lib.rs#L24-L24

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #2611

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants