chore(starknet_l1_provider_types): add crate

Cargo.toml

@@ -40,6 +40,7 @@ members = [
   "crates/starknet_http_server",
   "crates/starknet_integration_tests",
   "crates/starknet_l1_provider",
+  "crates/starknet_l1_provider_types",
   "crates/starknet_mempool",
   "crates/starknet_mempool_p2p",
   "crates/starknet_mempool_p2p_types",
@@ -222,6 +223,7 @@ starknet_gateway = { path = "crates/starknet_gateway", version = "0.0.0" }
 starknet_gateway_types = { path = "crates/starknet_gateway_types", version = "0.0.0" }
 starknet_http_server = { path = "crates/starknet_http_server", version = "0.0.0" }
 starknet_l1_provider = { path = "crates/starknet_l1_provider", version = "0.0.0" }
+starknet_l1_provider_types = { path = "crates/starknet_l1_provider_types", version = "0.0.0" }
 starknet_mempool = { path = "crates/starknet_mempool", version = "0.0.0" }
 starknet_mempool_p2p = { path = "crates/starknet_mempool_p2p", version = "0.0.0" }
 starknet_mempool_p2p_types = { path = "crates/starknet_mempool_p2p_types", version = "0.0.0" }

commitlint.config.js

@@ -61,6 +61,7 @@ const Configuration = {
             'starknet_http_server',
             'starknet_integration_tests',
             'starknet_l1_provider',
+            'starknet_l1_provider_types',
             'starknet_mempool',
             'starknet_mempool_p2p',
             'starknet_mempool_p2p_types',

crates/starknet_l1_provider/Cargo.toml

@@ -8,8 +8,8 @@ license.workspace = true
 [dependencies]
 indexmap.workspace = true
 papyrus_base_layer.workspace = true
-serde.workspace = true
 starknet_api.workspace = true
+starknet_l1_provider_types.workspace = true
 thiserror.workspace = true
 
 [dev-dependencies]

crates/starknet_l1_provider/src/errors.rs

@@ -1,31 +1,6 @@
 use papyrus_base_layer::ethereum_base_layer_contract::EthereumBaseLayerError;
-use serde::{Deserialize, Serialize};
 use thiserror::Error;
 
-#[derive(Clone, Debug, Error, PartialEq, Eq, Serialize, Deserialize)]
-pub enum L1ProviderError {
-    #[error(
-        "`get_txs` called while in `Pending` state, likely due to a crash; restart block proposal"
-    )]
-    GetTransactionsInPendingState,
-    #[error("`get_txs` while in validate state")]
-    GetTransactionConsensusBug,
-    #[error("Cannot transition from {from} to {to}")]
-    UnexpectedProviderStateTransition { from: String, to: String },
-    #[error(
-        "`validate` called while in `Pending` state, likely due to a crash; restart block proposal"
-    )]
-    ValidateInPendingState,
-    #[error("`validate` called while in `Propose`")]
-    ValidateTransactionConsensusBug,
-}
-
-impl L1ProviderError {
-    pub fn unexpected_transition(from: impl ToString, to: impl ToString) -> Self {
-        Self::UnexpectedProviderStateTransition { from: from.to_string(), to: to.to_string() }
-    }
-}
-
 // TODO(Gilad): move to scraper module once it's created.
 #[derive(Error, Debug)]
 pub enum L1ScraperError {

crates/starknet_l1_provider/src/l1_provider_tests.rs

@@ -3,11 +3,12 @@ use pretty_assertions::assert_eq;
 use starknet_api::test_utils::l1_handler::executable_l1_handler_tx;
 use starknet_api::transaction::TransactionHash;
 use starknet_api::{l1_handler_tx_args, tx_hash};
+use starknet_l1_provider_types::errors::L1ProviderError;
+use starknet_l1_provider_types::ValidationStatus;
 
-use crate::errors::L1ProviderError;
 use crate::test_utils::L1ProviderContentBuilder;
+use crate::L1Provider;
 use crate::ProviderState::{Pending, Propose, Uninitialized, Validate};
-use crate::{L1Provider, ValidationStatus};
 
 macro_rules! tx {
     (tx_hash: $tx_hash:expr) => {{

crates/starknet_l1_provider/src/lib.rs

@@ -6,10 +6,8 @@ pub mod test_utils;
 use indexmap::{IndexMap, IndexSet};
 use starknet_api::executable_transaction::L1HandlerTransaction;
 use starknet_api::transaction::TransactionHash;
-
-use crate::errors::L1ProviderError;
-
-type L1ProviderResult<T> = Result<T, L1ProviderError>;
+use starknet_l1_provider_types::errors::L1ProviderError;
+use starknet_l1_provider_types::{L1ProviderResult, ValidationStatus};
 
 #[cfg(test)]
 #[path = "l1_provider_tests.rs"]
@@ -142,13 +140,6 @@ impl TransactionManager {
     }
 }
 
-#[derive(Clone, Copy, Debug, Eq, PartialEq)]
-pub enum ValidationStatus {
-    Validated,
-    AlreadyIncludedOnL2,
-    ConsumedOnL1OrUnknown,
-}
-
 /// Current state of the provider, where pending means: idle, between proposal/validation cycles.
 #[derive(Clone, Copy, Debug, Default, Eq, PartialEq)]
 pub enum ProviderState {

crates/starknet_l1_provider_types/Cargo.toml

@@ -0,0 +1,13 @@
+[package]
+name = "starknet_l1_provider_types"
+version.workspace = true
+edition.workspace = true
+repository.workspace = true
+license.workspace = true
+
+[dependencies]
+serde.workspace = true
+thiserror.workspace = true
+
+[lints]
+workspace = true

crates/starknet_l1_provider_types/src/errors.rs

@@ -0,0 +1,28 @@
+use std::fmt::Debug;
+
+use serde::{Deserialize, Serialize};
+use thiserror::Error;
+
+#[derive(Clone, Debug, Error, PartialEq, Eq, Serialize, Deserialize)]
+pub enum L1ProviderError {
+    #[error(
+        "`get_txs` called while in `Pending` state, likely due to a crash; restart block proposal"
+    )]
+    GetTransactionsInPendingState,
+    #[error("`get_txs` while in validate state")]
+    GetTransactionConsensusBug,
+    #[error("Cannot transition from {from} to {to}")]
+    UnexpectedProviderStateTransition { from: String, to: String },
+    #[error(
+        "`validate` called while in `Pending` state, likely due to a crash; restart block proposal"
+    )]
+    ValidateInPendingState,
+    #[error("`validate` called while in `Propose`")]
+    ValidateTransactionConsensusBug,
+}
+
+impl L1ProviderError {
+    pub fn unexpected_transition(from: impl ToString, to: impl ToString) -> Self {
+        Self::UnexpectedProviderStateTransition { from: from.to_string(), to: to.to_string() }
+    }
+}

crates/starknet_l1_provider_types/src/lib.rs

@@ -0,0 +1,12 @@
+pub mod errors;
+
+use crate::errors::L1ProviderError;
+
+pub type L1ProviderResult<T> = Result<T, L1ProviderError>;
+
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+pub enum ValidationStatus {
+    Validated,
+    AlreadyIncludedOnL2,
+    ConsumedOnL1OrUnknown,
+}