Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_l1_provider_types): add crate #2579

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

giladchase
Copy link
Contributor

Only move, no logic changes, this is a setup for upcoming infra support.

@giladchase giladchase requested a review from elintul December 9, 2024 11:12
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.42%. Comparing base (e3165c4) to head (8a8f9ae).
Report is 774 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_l1_provider_types/src/errors.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2579       +/-   ##
===========================================
+ Coverage   40.10%   77.42%   +37.31%     
===========================================
  Files          26      387      +361     
  Lines        1895    41454    +39559     
  Branches     1895    41454    +39559     
===========================================
+ Hits          760    32095    +31335     
- Misses       1100     7091     +5991     
- Partials       35     2268     +2233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giladchase giladchase force-pushed the gilad/l1-provider-types branch from 2780606 to 502b871 Compare December 9, 2024 12:27
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase force-pushed the gilad/l1-provider-types branch from 502b871 to c2916c4 Compare December 9, 2024 12:42
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase force-pushed the gilad/l1-provider-types branch from c2916c4 to 36007af Compare December 9, 2024 12:48
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase force-pushed the gilad/l1-provider-types branch from 36007af to e1fe42a Compare December 9, 2024 13:17
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

Copy link

github-actions bot commented Dec 9, 2024

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.782 ms 35.016 ms 35.297 ms]
change: [+1.0074% +1.6837% +2.6700%] (p = 0.00 < 0.05)
Performance has regressed.
Found 15 outliers among 100 measurements (15.00%)
2 (2.00%) high mild
13 (13.00%) high severe

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

Only move, no logic changes, this is a setup for upcoming infra support.
@giladchase giladchase force-pushed the gilad/l1-provider-types branch from e1fe42a to 8a8f9ae Compare December 9, 2024 13:26
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase merged commit 99493e2 into main Dec 9, 2024
23 checks passed
@giladchase giladchase deleted the gilad/l1-provider-types branch December 9, 2024 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants