chore(blockifier): add field sierra_gas to BouncerWeights #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
===========================================
+ Coverage 40.10% 66.20% +26.10%
===========================================
Files 26 153 +127
Lines 1895 19579 +17684
Branches 1895 19579 +17684
===========================================
+ Hits 760 12963 +12203
- Misses 1100 5809 +4709
- Partials 35 807 +772 ☔ View full report in Codecov by Sentry. |
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
from
1fcee88 to
698a9c0
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
16615fa to
d64ab78
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
2 times, most recently
from
03a1ffb to
3748ee3
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
d64ab78 to
3c43b6d
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
from
3748ee3 to
b59d57a
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
from
b59d57a to
f92b04f
Compare
There was a problem hiding this comment.
This PR should not be rebased on top of the L1 gas; they are independent.
Reviewed 1 of 7 files at r1, all commit messages.
Reviewable status: 1 of 7 files reviewed, all discussions resolved
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
3c43b6d to
d8a5d28
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
from
f92b04f to
b5e6f5f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
d8a5d28 to
ac83627
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
2 times, most recently
from
46b0107 to
3900a55
Compare
avivg-starkware
changed the base branch from
avivg/blockifier/bouncer_rename_gas_to_l1gas
to
main
avivg-starkware
commented
Dec 9, 2024
There was a problem hiding this comment.
Moved. Thankyou.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
|
Benchmark movements: |
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
from
3900a55 to
9d89d63
Compare
Yoni-Starkware
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Reviewed 2 of 5 files at r2, all commit messages.
Reviewable status: 2 of 7 files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)
crates/blockifier/src/bouncer_test.rs line 90 at r2 (raw file):
n_events: 5, state_diff_size: 5, sierra_gas: GasAmount(5), // TODO(AvivG): replace w desired val.
It's just a test so it's okay
x2
Suggestion:
sierra_gas: GasAmount(5),crates/blockifier/src/bouncer.rs line 155 at r2 (raw file):
state_diff_size: 4000, builtin_count: BuiltinCount::default(), sierra_gas: GasAmount(1000000), // TODO(AvivG): replace w desired val.
Suggestion:
sierra_gas: GasAmount(250000000),
Yoni-Starkware
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Reviewable status: 2 of 7 files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)
crates/blockifier/src/bouncer_test.rs line 90 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
It's just a test so it's okay
x2
All over this file
Yoni-Starkware
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 7 files at r1, 1 of 5 files at r2.
Reviewable status: 4 of 7 files reviewed, 3 unresolved discussions (waiting on @avivg-starkware)
crates/native_blockifier/src/py_objects.rs line 130 at r2 (raw file):
let n_events = data.remove(constants::N_EVENTS).expect("n_events must be present"); let sierra_gas = GasAmount( data.remove(constants::SIERRA_GAS).expect("sierra_gas must be present").try_into().unwrap(),
Add a message
Code quote:
.unwrap()
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
2 times, most recently
from
43e85ed to
290720f
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
from
290720f to
75385cc
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_weights_add_sierra_gas
branch
from
75385cc to
70af3ef
Compare
avivg-starkware
commented
Dec 10, 2024
There was a problem hiding this comment.
Reviewable status: 1 of 7 files reviewed, 4 unresolved discussions (waiting on @Yoni-Starkware)
crates/blockifier/src/bouncer_test.rs line 90 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
All over this file
should the sierra_gas val match the l1_gas? (as currently)
crates/native_blockifier/src/py_objects.rs line 130 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Add a message
Added
crates/blockifier/src/bouncer.rs line 155 at r2 (raw file):
state_diff_size: 4000, builtin_count: BuiltinCount::default(), sierra_gas: GasAmount(1000000), // TODO(AvivG): replace w desired val.
Done.
deployments/sequencer/references/sequencer-node/ConfigMap.sequencer-node-config.k8s.yaml line 7 at r3 (raw file):
namespace: test data: config: "{\"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.add_mod\": {\"description\": \"Max number of add mod builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 156250}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.bitwise\": {\"description\": \"Max number of bitwise builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 39062}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.ec_op\": {\"description\": \"Max number of EC operation builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 2441}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.ecdsa\": {\"description\": \"Max number of ECDSA builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 1220}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.keccak\": {\"description\": \"Max number of keccak builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 1220}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.mul_mod\": {\"description\": \"Max number of mul mod builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 156250}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.pedersen\": {\"description\": \"Max number of pedersen builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 78125}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.poseidon\": {\"description\": \"Max number of poseidon builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 78125}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.range_check\": {\"description\": \"Max number of range check builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 156250}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.builtin_count.range_check96\": {\"description\": \"Max number of range check 96 builtin usage in a block.\", \"privacy\": \"Public\", \"value\": 156250}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.l1_gas\": {\"description\": \"An upper bound on the total gas used in a block.\", \"privacy\": \"Public\", \"value\": 2500000}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.message_segment_length\": {\"description\": \"An upper bound on the message segment length in a block.\", \"privacy\": \"Public\", \"value\": 3700}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.n_events\": {\"description\": \"An upper bound on the total number of events generated in a block.\", \"privacy\": \"Public\", \"value\": 5000}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.n_steps\": {\"description\": \"An upper bound on the total number of steps in a block.\", \"privacy\": \"Public\", \"value\": 2500000}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.state_diff_size\": {\"description\": \"An upper bound on the total state diff size in a block.\", \"privacy\": \"Public\", \"value\": 4000}, \"batcher_config.block_builder_config.bouncer_config.block_max_capacity.sierra_gas\": {\"description\": \"An upper bound on the total sierra_gas used in a block.\", \"privacy\": \"Public\", \"value\": 1000000}, \"batcher_config.block_builder_config.chain_info.chain_id\": {\"description\": \"The chain ID of the StarkNet chain.\", \"pointer_target\": \"chain_id\", \"privacy\": \"Public\"}, \"batcher_config.block_builder_config.chain_info.fee_token_addresses.eth_fee_token_address\": {\"description\": \"Address of the ETH fee token.\", \"pointer_target\": \"eth_fee_token_address\", \"privacy\": \"Public\"}, \"batcher_config.block_builder_config.chain_info.fee_token_addresses.strk_fee_token_address\": {\"description\": \"Address of the STRK fee token.\", \"pointer_target\": \"strk_fee_token_address\", \"privacy\": \"Public\"}, \"batcher_config.block_builder_config.execute_config.concurrency_config.chunk_size\": {\"description\": \"The size of the transaction chunk executed in parallel.\", \"privacy\": \"Public\", \"value\": 0}, \"batcher_config.block_builder_config.execute_config.concurrency_config.enabled\": {\"description\": \"Enables concurrency of transaction execution.\", \"privacy\": \"Public\", \"value\": false}, \"batcher_config.block_builder_config.execute_config.concurrency_config.n_workers\": {\"description\": \"Number of parallel transaction execution workers.\", \"privacy\": \"Public\", \"value\": 0}, \"batcher_config.block_builder_config.sequencer_address\": {\"description\": \"The address of the sequencer.\", \"pointer_target\": \"sequencer_address\", \"privacy\": \"Public\"}, \"batcher_config.block_builder_config.tx_chunk_size\": {\"description\": \"The size of the transaction chunk.\", \"privacy\": \"Public\", \"value\": 100}, \"batcher_config.block_builder_config.use_kzg_da\": {\"description\": \"Indicates whether the kzg mechanism is used for data availability.\", \"privacy\": \"Public\", \"value\": true}, \"batcher_config.block_builder_config.versioned_constants_overrides.invoke_tx_max_n_steps\": {\"description\": \"Maximum number of steps the invoke function is allowed to run.\", \"pointer_target\": \"versioned_constants_overrides.invoke_tx_max_n_steps\", \"privacy\": \"Public\"}, \"batcher_config.block_builder_config.versioned_constants_overrides.max_recursion_depth\": {\"description\": \"Maximum recursion depth for nested calls during blockifier validation.\", \"pointer_target\": \"versioned_constants_overrides.max_recursion_depth\", \"privacy\": \"Public\"}, \"batcher_config.block_builder_config.versioned_constants_overrides.validate_max_n_steps\": {\"description\": \"Maximum number of steps the validation function is allowed to run.\", \"pointer_target\": \"versioned_constants_overrides.validate_max_n_steps\", \"privacy\": \"Public\"}, \"batcher_config.global_contract_cache_size\": {\"description\": \"Cache size for the global_class_hash_to_class. Initialized with this size on creation.\", \"privacy\": \"Public\", \"value\": 400}, \"batcher_config.input_stream_content_buffer_size\": {\"description\": \"Sets the buffer size for the input transaction channel. Adding more transactions beyond this limit will block until space is available.\", \"privacy\": \"Public\", \"value\": 400}, \"batcher_config.max_l1_handler_txs_per_block_proposal\": {\"description\": \"The maximum number of L1 handler transactions to include in a block proposal.\", \"privacy\": \"Public\", \"value\": 3}, \"batcher_config.outstream_content_buffer_size\": {\"description\": \"The maximum number of items to include in a single get_proposal_content response.\", \"privacy\": \"Public\", \"value\": 100}, \"batcher_config.storage.db_config.chain_id\": {\"description\": \"The chain to follow. For more details see https://docs.starknet.io/documentation/architecture_and_concepts/Blocks/transactions/#chain-id.\", \"pointer_target\": \"chain_id\", \"privacy\": \"Public\"}, \"batcher_config.storage.db_config.enforce_file_exists\": false, \"batcher_config.storage.db_config.growth_step\": {\"description\": \"The growth step in bytes, must be greater than zero to allow the database to grow.\", \"privacy\": \"Public\", \"value\": 4294967296}, \"batcher_config.storage.db_config.max_size\": {\"description\": \"The maximum size of the node's storage in bytes.\", \"privacy\": \"Public\", \"value\": 1099511627776}, \"batcher_config.storage.db_config.min_size\": {\"description\": \"The minimum size of the node's storage in bytes.\", \"privacy\": \"Public\", \"value\": 1048576}, \"batcher_config.storage.db_config.path_prefix\": \"/data\", \"batcher_config.storage.mmap_file_config.growth_step\": {\"description\": \"The growth step in bytes, must be greater than max_object_size.\", \"privacy\": \"Public\", \"value\": 1073741824}, \"batcher_config.storage.mmap_file_config.max_object_size\": {\"description\": \"The maximum size of a single object in the file in bytes\", \"privacy\": \"Public\", \"value\": 268435456}, \"batcher_config.storage.mmap_file_config.max_size\": {\"description\": \"The maximum size of a memory mapped file in bytes. Must be greater than growth_step.\", \"privacy\": \"Public\", \"value\": 1099511627776}, \"batcher_config.storage.scope\": {\"description\": \"The categories of data saved in storage.\", \"privacy\": \"Public\", \"value\": \"StateOnly\"}, \"chain_id\": \"0x5\", \"compiler_config.max_bytecode_size\": {\"description\": \"Limitation of contract bytecode size.\", \"privacy\": \"Public\", \"value\": 81920}, \"components.batcher.execution_mode\": \"Disabled\", \"components.batcher.local_server_config.#is_none\": true, \"components.batcher.local_server_config.channel_buffer_size\": {\"description\": \"The communication channel buffer size.\", \"privacy\": \"Public\", \"value\": 32}, \"components.batcher.remote_client_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.batcher.remote_client_config.idle_connections\": {\"description\": \"The maximum number of idle connections to keep alive.\", \"privacy\": \"Public\", \"value\": 18446744073709551615}, \"components.batcher.remote_client_config.idle_timeout\": {\"description\": \"The duration in seconds to keep an idle connection open before closing.\", \"privacy\": \"Public\", \"value\": 90}, \"components.batcher.remote_client_config.retries\": {\"description\": \"The max number of retries for sending a message.\", \"privacy\": \"Public\", \"value\": 3}, \"components.batcher.remote_client_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.batcher.remote_server_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.batcher.remote_server_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.consensus_manager.execution_mode\": \"Disabled\", \"components.consensus_manager.local_server_config.#is_none\": true, \"components.consensus_manager.local_server_config.channel_buffer_size\": {\"description\": \"The communication channel buffer size.\", \"privacy\": \"Public\", \"value\": 32}, \"components.consensus_manager.remote_client_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.consensus_manager.remote_client_config.idle_connections\": {\"description\": \"The maximum number of idle connections to keep alive.\", \"privacy\": \"Public\", \"value\": 18446744073709551615}, \"components.consensus_manager.remote_client_config.idle_timeout\": {\"description\": \"The duration in seconds to keep an idle connection open before closing.\", \"privacy\": \"Public\", \"value\": 90}, \"components.consensus_manager.remote_client_config.retries\": {\"description\": \"The max number of retries for sending a message.\", \"privacy\": \"Public\", \"value\": 3}, \"components.consensus_manager.remote_client_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.consensus_manager.remote_server_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.consensus_manager.remote_server_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.gateway.execution_mode\": \"Disabled\", \"components.gateway.local_server_config.#is_none\": true, \"components.gateway.local_server_config.channel_buffer_size\": {\"description\": \"The communication channel buffer size.\", \"privacy\": \"Public\", \"value\": 32}, \"components.gateway.remote_client_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.gateway.remote_client_config.idle_connections\": {\"description\": \"The maximum number of idle connections to keep alive.\", \"privacy\": \"Public\", \"value\": 18446744073709551615}, \"components.gateway.remote_client_config.idle_timeout\": {\"description\": \"The duration in seconds to keep an idle connection open before closing.\", \"privacy\": \"Public\", \"value\": 90}, \"components.gateway.remote_client_config.retries\": {\"description\": \"The max number of retries for sending a message.\", \"privacy\": \"Public\", \"value\": 3}, \"components.gateway.remote_client_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.gateway.remote_server_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.gateway.remote_server_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.http_server.execution_mode\": \"Disabled\", \"components.http_server.local_server_config.#is_none\": true, \"components.http_server.local_server_config.channel_buffer_size\": {\"description\": \"The communication channel buffer size.\", \"privacy\": \"Public\", \"value\": 32}, \"components.http_server.remote_client_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.http_server.remote_client_config.idle_connections\": {\"description\": \"The maximum number of idle connections to keep alive.\", \"privacy\": \"Public\", \"value\": 18446744073709551615}, \"components.http_server.remote_client_config.idle_timeout\": {\"description\": \"The duration in seconds to keep an idle connection open before closing.\", \"privacy\": \"Public\", \"value\": 90}, \"components.http_server.remote_client_config.retries\": {\"description\": \"The max number of retries for sending a message.\", \"privacy\": \"Public\", \"value\": 3}, \"components.http_server.remote_client_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.http_server.remote_server_config.#is_none\": true, \"components.http_server.remote_server_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.mempool.execution_mode\": \"Disabled\", \"components.mempool.local_server_config.#is_none\": true, \"components.mempool.local_server_config.channel_buffer_size\": {\"description\": \"The communication channel buffer size.\", \"privacy\": \"Public\", \"value\": 32}, \"components.mempool.remote_client_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.mempool.remote_client_config.idle_connections\": {\"description\": \"The maximum number of idle connections to keep alive.\", \"privacy\": \"Public\", \"value\": 18446744073709551615}, \"components.mempool.remote_client_config.idle_timeout\": {\"description\": \"The duration in seconds to keep an idle connection open before closing.\", \"privacy\": \"Public\", \"value\": 90}, \"components.mempool.remote_client_config.retries\": {\"description\": \"The max number of retries for sending a message.\", \"privacy\": \"Public\", \"value\": 3}, \"components.mempool.remote_client_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.mempool.remote_server_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.mempool.remote_server_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.mempool_p2p.execution_mode\": \"Disabled\", \"components.mempool_p2p.local_server_config.#is_none\": true, \"components.mempool_p2p.local_server_config.channel_buffer_size\": {\"description\": \"The communication channel buffer size.\", \"privacy\": \"Public\", \"value\": 32}, \"components.mempool_p2p.remote_client_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.mempool_p2p.remote_client_config.idle_connections\": {\"description\": \"The maximum number of idle connections to keep alive.\", \"privacy\": \"Public\", \"value\": 18446744073709551615}, \"components.mempool_p2p.remote_client_config.idle_timeout\": {\"description\": \"The duration in seconds to keep an idle connection open before closing.\", \"privacy\": \"Public\", \"value\": 90}, \"components.mempool_p2p.remote_client_config.retries\": {\"description\": \"The max number of retries for sending a message.\", \"privacy\": \"Public\", \"value\": 3}, \"components.mempool_p2p.remote_client_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.mempool_p2p.remote_server_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.mempool_p2p.remote_server_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.monitoring_endpoint.execution_mode\": {\"description\": \"The component execution mode.\", \"privacy\": \"Public\", \"value\": \"LocalExecutionWithRemoteEnabled\"}, \"components.monitoring_endpoint.local_server_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": false}, \"components.monitoring_endpoint.local_server_config.channel_buffer_size\": {\"description\": \"The communication channel buffer size.\", \"privacy\": \"Public\", \"value\": 32}, \"components.monitoring_endpoint.remote_client_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.monitoring_endpoint.remote_client_config.idle_connections\": {\"description\": \"The maximum number of idle connections to keep alive.\", \"privacy\": \"Public\", \"value\": 18446744073709551615}, \"components.monitoring_endpoint.remote_client_config.idle_timeout\": {\"description\": \"The duration in seconds to keep an idle connection open before closing.\", \"privacy\": \"Public\", \"value\": 90}, \"components.monitoring_endpoint.remote_client_config.retries\": {\"description\": \"The max number of retries for sending a message.\", \"privacy\": \"Public\", \"value\": 3}, \"components.monitoring_endpoint.remote_client_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.monitoring_endpoint.remote_server_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": false}, \"components.monitoring_endpoint.remote_server_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.state_sync.execution_mode\": {\"description\": \"The component execution mode.\", \"privacy\": \"Public\", \"value\": \"LocalExecutionWithRemoteDisabled\"}, \"components.state_sync.local_server_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": false}, \"components.state_sync.local_server_config.channel_buffer_size\": {\"description\": \"The communication channel buffer size.\", \"privacy\": \"Public\", \"value\": 32}, \"components.state_sync.remote_client_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.state_sync.remote_client_config.idle_connections\": {\"description\": \"The maximum number of idle connections to keep alive.\", \"privacy\": \"Public\", \"value\": 18446744073709551615}, \"components.state_sync.remote_client_config.idle_timeout\": {\"description\": \"The duration in seconds to keep an idle connection open before closing.\", \"privacy\": \"Public\", \"value\": 90}, \"components.state_sync.remote_client_config.retries\": {\"description\": \"The max number of retries for sending a message.\", \"privacy\": \"Public\", \"value\": 3}, \"components.state_sync.remote_client_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"components.state_sync.remote_server_config.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"components.state_sync.remote_server_config.socket\": {\"description\": \"The remote component server socket.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0:8080\"}, \"consensus_manager_config.consensus_config.consensus_delay\": {\"description\": \"Delay (seconds) before starting consensus to give time for network peering.\", \"privacy\": \"Public\", \"value\": 5}, \"consensus_manager_config.consensus_config.network_config.advertised_multiaddr\": {\"description\": \"The external address other peers see this node. If this is set, the node will not try to find out which addresses it has and will write this address as external instead\", \"privacy\": \"Public\", \"value\": \"\"}, \"consensus_manager_config.consensus_config.network_config.advertised_multiaddr.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"consensus_manager_config.consensus_config.network_config.bootstrap_peer_multiaddr\": {\"description\": \"The multiaddress of the peer node. It should include the peer's id. For more info: https://docs.libp2p.io/concepts/fundamentals/peers/\", \"privacy\": \"Public\", \"value\": \"\"}, \"consensus_manager_config.consensus_config.network_config.bootstrap_peer_multiaddr.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"consensus_manager_config.consensus_config.network_config.chain_id\": {\"description\": \"The chain to follow. For more details see https://docs.starknet.io/documentation/architecture_and_concepts/Blocks/transactions/#chain-id.\", \"pointer_target\": \"chain_id\", \"privacy\": \"Public\"}, \"consensus_manager_config.consensus_config.network_config.discovery_config.bootstrap_dial_retry_config.base_delay_millis\": {\"description\": \"The base delay in milliseconds for the exponential backoff strategy.\", \"privacy\": \"Public\", \"value\": 2}, \"consensus_manager_config.consensus_config.network_config.discovery_config.bootstrap_dial_retry_config.factor\": {\"description\": \"The factor for the exponential backoff strategy.\", \"privacy\": \"Public\", \"value\": 5}, \"consensus_manager_config.consensus_config.network_config.discovery_config.bootstrap_dial_retry_config.max_delay_seconds\": {\"description\": \"The maximum delay in seconds for the exponential backoff strategy.\", \"privacy\": \"Public\", \"value\": 5}, \"consensus_manager_config.consensus_config.network_config.discovery_config.heartbeat_interval\": {\"description\": \"The interval between each discovery (Kademlia) query in milliseconds.\", \"privacy\": \"Public\", \"value\": 100}, \"consensus_manager_config.consensus_config.network_config.idle_connection_timeout\": {\"description\": \"Amount of time in seconds that a connection with no active sessions will stay alive.\", \"privacy\": \"Public\", \"value\": 120}, \"consensus_manager_config.consensus_config.network_config.peer_manager_config.malicious_timeout_seconds\": {\"description\": \"The duration in seconds a peer is blacklisted after being marked as malicious.\", \"privacy\": \"Public\", \"value\": 31536000}, \"consensus_manager_config.consensus_config.network_config.peer_manager_config.unstable_timeout_millis\": {\"description\": \"The duration in milliseconds a peer blacklisted after being reported as unstable.\", \"privacy\": \"Public\", \"value\": 1000}, \"consensus_manager_config.consensus_config.network_config.quic_port\": {\"description\": \"The port that the node listens on for incoming quic connections.\", \"privacy\": \"Public\", \"value\": 10101}, \"consensus_manager_config.consensus_config.network_config.secret_key\": {\"description\": \"The secret key used for building the peer id. If it's an empty string a random one will be used.\", \"privacy\": \"Private\", \"value\": \"\"}, \"consensus_manager_config.consensus_config.network_config.session_timeout\": {\"description\": \"Maximal time in seconds that each session can take before failing on timeout.\", \"privacy\": \"Public\", \"value\": 120}, \"consensus_manager_config.consensus_config.network_config.tcp_port\": {\"description\": \"The port that the node listens on for incoming tcp connections.\", \"privacy\": \"Public\", \"value\": 10100}, \"consensus_manager_config.consensus_config.network_topic\": {\"description\": \"The network topic of the consensus.\", \"privacy\": \"Public\", \"value\": \"consensus\"}, \"consensus_manager_config.consensus_config.num_validators\": {\"description\": \"The number of validators in the consensus.\", \"privacy\": \"Public\", \"value\": 1}, \"consensus_manager_config.consensus_config.start_height\": {\"description\": \"The height to start the consensus from.\", \"privacy\": \"Public\", \"value\": 0}, \"consensus_manager_config.consensus_config.timeouts.precommit_timeout\": {\"description\": \"The timeout (seconds) for a precommit.\", \"privacy\": \"Public\", \"value\": 1.0}, \"consensus_manager_config.consensus_config.timeouts.prevote_timeout\": {\"description\": \"The timeout (seconds) for a prevote.\", \"privacy\": \"Public\", \"value\": 1.0}, \"consensus_manager_config.consensus_config.timeouts.proposal_timeout\": {\"description\": \"The timeout (seconds) for a proposal.\", \"privacy\": \"Public\", \"value\": 3.0}, \"consensus_manager_config.consensus_config.validator_id\": {\"description\": \"The validator id of the node.\", \"privacy\": \"Public\", \"value\": \"0x0\"}, \"eth_fee_token_address\": \"0x6\", \"gateway_config.chain_info.chain_id\": {\"description\": \"The chain ID of the StarkNet chain.\", \"pointer_target\": \"chain_id\", \"privacy\": \"Public\"}, \"gateway_config.chain_info.fee_token_addresses.eth_fee_token_address\": {\"description\": \"Address of the ETH fee token.\", \"pointer_target\": \"eth_fee_token_address\", \"privacy\": \"Public\"}, \"gateway_config.chain_info.fee_token_addresses.strk_fee_token_address\": {\"description\": \"Address of the STRK fee token.\", \"pointer_target\": \"strk_fee_token_address\", \"privacy\": \"Public\"}, \"gateway_config.stateful_tx_validator_config.max_nonce_for_validation_skip\": {\"description\": \"Maximum nonce for which the validation is skipped.\", \"privacy\": \"Public\", \"value\": \"0x1\"}, \"gateway_config.stateful_tx_validator_config.versioned_constants_overrides.invoke_tx_max_n_steps\": {\"description\": \"Maximum number of steps the invoke function is allowed to run.\", \"pointer_target\": \"versioned_constants_overrides.invoke_tx_max_n_steps\", \"privacy\": \"Public\"}, \"gateway_config.stateful_tx_validator_config.versioned_constants_overrides.max_recursion_depth\": {\"description\": \"Maximum recursion depth for nested calls during blockifier validation.\", \"pointer_target\": \"versioned_constants_overrides.max_recursion_depth\", \"privacy\": \"Public\"}, \"gateway_config.stateful_tx_validator_config.versioned_constants_overrides.validate_max_n_steps\": {\"description\": \"Maximum number of steps the validation function is allowed to run.\", \"pointer_target\": \"versioned_constants_overrides.validate_max_n_steps\", \"privacy\": \"Public\"}, \"gateway_config.stateless_tx_validator_config.max_calldata_length\": {\"description\": \"Limitation of calldata length.\", \"privacy\": \"Public\", \"value\": 4000}, \"gateway_config.stateless_tx_validator_config.max_contract_class_object_size\": {\"description\": \"Limitation of contract class object size.\", \"privacy\": \"Public\", \"value\": 4089446}, \"gateway_config.stateless_tx_validator_config.max_sierra_version.major\": {\"description\": \"The major version of the configuration.\", \"privacy\": \"Public\", \"value\": 1}, \"gateway_config.stateless_tx_validator_config.max_sierra_version.minor\": {\"description\": \"The minor version of the configuration.\", \"privacy\": \"Public\", \"value\": 5}, \"gateway_config.stateless_tx_validator_config.max_sierra_version.patch\": {\"description\": \"The patch version of the configuration.\", \"privacy\": \"Public\", \"value\": 18446744073709551615}, \"gateway_config.stateless_tx_validator_config.max_signature_length\": {\"description\": \"Limitation of signature length.\", \"privacy\": \"Public\", \"value\": 4000}, \"gateway_config.stateless_tx_validator_config.min_sierra_version.major\": {\"description\": \"The major version of the configuration.\", \"privacy\": \"Public\", \"value\": 1}, \"gateway_config.stateless_tx_validator_config.min_sierra_version.minor\": {\"description\": \"The minor version of the configuration.\", \"privacy\": \"Public\", \"value\": 1}, \"gateway_config.stateless_tx_validator_config.min_sierra_version.patch\": {\"description\": \"The patch version of the configuration.\", \"privacy\": \"Public\", \"value\": 0}, \"gateway_config.stateless_tx_validator_config.validate_non_zero_l1_data_gas_fee\": {\"description\": \"If true, validates that a transaction has non-zero L1 Data (Blob) resource bounds.\", \"privacy\": \"Public\", \"value\": false}, \"gateway_config.stateless_tx_validator_config.validate_non_zero_l1_gas_fee\": {\"description\": \"If true, validates that a transaction has non-zero L1 resource bounds.\", \"privacy\": \"Public\", \"value\": true}, \"gateway_config.stateless_tx_validator_config.validate_non_zero_l2_gas_fee\": {\"description\": \"If true, validates that a transaction has non-zero L2 resource bounds.\", \"privacy\": \"Public\", \"value\": false}, \"http_server_config.ip\": {\"description\": \"The http server ip.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0\"}, \"http_server_config.port\": {\"description\": \"The http server port.\", \"privacy\": \"Public\", \"value\": 8080}, \"mempool_p2p_config.network_buffer_size\": {\"description\": \"Network buffer size.\", \"privacy\": \"Public\", \"value\": 10000}, \"mempool_p2p_config.network_config.advertised_multiaddr\": {\"description\": \"The external address other peers see this node. If this is set, the node will not try to find out which addresses it has and will write this address as external instead\", \"privacy\": \"Public\", \"value\": \"\"}, \"mempool_p2p_config.network_config.advertised_multiaddr.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"mempool_p2p_config.network_config.bootstrap_peer_multiaddr\": {\"description\": \"The multiaddress of the peer node. It should include the peer's id. For more info: https://docs.libp2p.io/concepts/fundamentals/peers/\", \"privacy\": \"Public\", \"value\": \"\"}, \"mempool_p2p_config.network_config.bootstrap_peer_multiaddr.#is_none\": {\"description\": \"Flag for an optional field.\", \"privacy\": \"TemporaryValue\", \"value\": true}, \"mempool_p2p_config.network_config.chain_id\": {\"description\": \"The chain to follow. For more details see https://docs.starknet.io/documentation/architecture_and_concepts/Blocks/transactions/#chain-id.\", \"pointer_target\": \"chain_id\", \"privacy\": \"Public\"}, \"mempool_p2p_config.network_config.discovery_config.bootstrap_dial_retry_config.base_delay_millis\": {\"description\": \"The base delay in milliseconds for the exponential backoff strategy.\", \"privacy\": \"Public\", \"value\": 2}, \"mempool_p2p_config.network_config.discovery_config.bootstrap_dial_retry_config.factor\": {\"description\": \"The factor for the exponential backoff strategy.\", \"privacy\": \"Public\", \"value\": 5}, \"mempool_p2p_config.network_config.discovery_config.bootstrap_dial_retry_config.max_delay_seconds\": {\"description\": \"The maximum delay in seconds for the exponential backoff strategy.\", \"privacy\": \"Public\", \"value\": 5}, \"mempool_p2p_config.network_config.discovery_config.heartbeat_interval\": {\"description\": \"The interval between each discovery (Kademlia) query in milliseconds.\", \"privacy\": \"Public\", \"value\": 100}, \"mempool_p2p_config.network_config.idle_connection_timeout\": {\"description\": \"Amount of time in seconds that a connection with no active sessions will stay alive.\", \"privacy\": \"Public\", \"value\": 120}, \"mempool_p2p_config.network_config.peer_manager_config.malicious_timeout_seconds\": {\"description\": \"The duration in seconds a peer is blacklisted after being marked as malicious.\", \"privacy\": \"Public\", \"value\": 31536000}, \"mempool_p2p_config.network_config.peer_manager_config.unstable_timeout_millis\": {\"description\": \"The duration in milliseconds a peer blacklisted after being reported as unstable.\", \"privacy\": \"Public\", \"value\": 1000}, \"mempool_p2p_config.network_config.quic_port\": {\"description\": \"The port that the node listens on for incoming quic connections.\", \"privacy\": \"Public\", \"value\": 10001}, \"mempool_p2p_config.network_config.secret_key\": {\"description\": \"The secret key used for building the peer id. If it's an empty string a random one will be used.\", \"privacy\": \"Private\", \"value\": \"\"}, \"mempool_p2p_config.network_config.session_timeout\": {\"description\": \"Maximal time in seconds that each session can take before failing on timeout.\", \"privacy\": \"Public\", \"value\": 120}, \"mempool_p2p_config.network_config.tcp_port\": {\"description\": \"The port that the node listens on for incoming tcp connections.\", \"privacy\": \"Public\", \"value\": 10000}, \"monitoring_endpoint_config.ip\": {\"description\": \"The monitoring endpoint ip address.\", \"privacy\": \"Public\", \"value\": \"0.0.0.0\"}, \"monitoring_endpoint_config.port\": {\"description\": \"The monitoring endpoint port.\", \"privacy\": \"Public\", \"value\": 8082}, \"rpc_state_reader_config.json_rpc_version\": {\"description\": \"The json rpc version.\", \"privacy\": \"Public\", \"value\": \"\"}, \"rpc_state_reader_config.url\": {\"description\": \"The url of the rpc server.\", \"privacy\": \"Public\", \"value\": \"\"}, \"sequencer_address\": {\"description\": \"A required param! The sequencer address.\", \"param_type\": \"String\", \"privacy\": \"TemporaryValue\"}, \"strk_fee_token_address\": \"0x7\", \"versioned_constants_overrides.invoke_tx_max_n_steps\": {\"description\": \"Maximum number of steps the invoke function is allowed to run.\", \"privacy\": \"TemporaryValue\", \"value\": 10000000}, \"versioned_constants_overrides.max_recursion_depth\": {\"description\": \"Maximum recursion depth for nested calls during blockifier validation.\", \"privacy\": \"TemporaryValue\", \"value\": 50}, \"versioned_constants_overrides.validate_max_n_steps\": {\"description\": \"Maximum number of steps the validation function is allowed to run.\", \"privacy\": \"TemporaryValue\", \"value\": 1000000}}"
1- I changed this manually, not sure if this is something that should be updated differently.
2- I added a change that should have been in the prev PR, as I only caught it after the merge of the first PR:
(l1gas >>> l1_gas)
Code snippet:
"batcher_config.block_builder_config.bouncer_config.block_max_capacity.l1gas
>>>>>>>>>>>
"batcher_config.block_builder_config.bouncer_config.block_max_capacity.l1_gas
Yoni-Starkware
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Reviewed 1 of 7 files at r1, 4 of 6 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
crates/blockifier/src/bouncer_test.rs line 90 at r2 (raw file):
Previously, avivg-starkware wrote…
should the sierra_gas val match the l1_gas? (as currently)
Yeah it's okay
avivg-starkware
commented
Dec 10, 2024
There was a problem hiding this comment.
Reviewed 1 of 7 files at r1, 4 of 6 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion
crates/starknet_api/src/execution_resources.rs line 15 at r4 (raw file):
derive_more::Sub, derive_more::Add, derive_more::AddAssign,
@avivg-starkware @Yoni-Starkware these derives are not in business logic on purpose.
we can use + and - in tests but we should explicitly saturate or check in all business logic.
Code quote:
derive_more::Sub,
derive_more::Add,
derive_more::AddAssign,
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.