chore(blockifier): rename BouncerWeights field gas to l1gas #2527
Conversation
|
This change is |
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
8ff7fc9 to
16615fa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2527 +/- ##
===========================================
+ Coverage 40.10% 58.98% +18.87%
===========================================
Files 26 171 +145
Lines 1895 19686 +17791
Branches 1895 19686 +17791
===========================================
+ Hits 760 11611 +10851
- Misses 1100 7319 +6219
- Partials 35 756 +721 ☔ View full report in Codecov by Sentry. |
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
16615fa to
d64ab78
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
d64ab78 to
3c43b6d
Compare
There was a problem hiding this comment.
Py side? (it should break)
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)
crates/blockifier/src/bouncer.rs line 106 at r1 (raw file):
impl_checked_sub!( builtin_count, l1gas,
Suggestion:
l1_gas
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
3c43b6d to
d8a5d28
Compare
There was a problem hiding this comment.
Still working on it, will put you on the PR as soon as it is ready to check
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
crates/blockifier/src/bouncer.rs line 106 at r1 (raw file):
impl_checked_sub!( builtin_count, l1gas,
Done.
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
d8a5d28 to
ac83627
Compare
There was a problem hiding this comment.
Reviewed 3 of 6 files at r2, all commit messages.
Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)
crates/blockifier/src/abi/constants.rs line 28 at r2 (raw file):
// Transaction resource names. // TODO(Amos, 1/10/2024): Rename to l1_gas_weight.
Revert, this is not related to your PR
Code quote:
// Transaction resource names.
// TODO(Amos, 1/10/2024): Rename to l1_gas_weight.There was a problem hiding this comment.
Reviewed 1 of 7 files at r1.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)
avivg-starkware
force-pushed
the
avivg/blockifier/bouncer_rename_gas_to_l1gas
branch
from
ac83627 to
f28b5c3
Compare
There was a problem hiding this comment.
Reviewable status: 4 of 7 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
crates/blockifier/src/abi/constants.rs line 28 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Revert, this is not related to your PR
Done.
There was a problem hiding this comment.
Reviewed 1 of 7 files at r1, 6 of 6 files at r2.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
There was a problem hiding this comment.
Reviewed 2 of 6 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @avivg-starkware)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)
No description provided.