Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restrict RemoteServers struct and field visibility #2125

Open
wants to merge 1 commit into
base: spr/main/485ed888
Choose a base branch
from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Nov 17, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (spr/main/485ed888@a015c8c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/starknet_sequencer_node/src/servers.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             spr/main/485ed888   #2125   +/-   ##
===================================================
  Coverage                     ?   5.93%           
===================================================
  Files                        ?     263           
  Lines                        ?   30622           
  Branches                     ?   30622           
===================================================
  Hits                         ?    1816           
  Misses                       ?   28732           
  Partials                     ?      74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants