Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor run_component_servers function #2124

Open
wants to merge 1 commit into
base: spr/main/02b017c7
Choose a base branch
from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Nov 17, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 83.62069% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.42%. Comparing base (b6c6bd3) to head (a015c8c).

Files with missing lines Patch % Lines
crates/starknet_sequencer_node/src/servers.rs 83.62% 13 Missing and 6 partials ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           spr/main/02b017c7    #2124       +/-   ##
======================================================
+ Coverage               5.93%   77.42%   +71.48%     
======================================================
  Files                    263      381      +118     
  Lines                  30586    40133     +9547     
  Branches               30586    40133     +9547     
======================================================
+ Hits                    1816    31071    +29255     
+ Misses                 28696     6772    -21924     
- Partials                  74     2290     +2216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Artifacts upload triggered. View details here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants