refactor(consensus): change the broadcast fn in context to take 'ref mut self' #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @matan-starkware and the rest of your teammates on |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
=======================================
Coverage 66.31% 66.31%
=======================================
Files 139 139
Lines 18341 18339 -2
Branches 18341 18339 -2
=======================================
- Hits 12163 12162 -1
+ Misses 4883 4881 -2
- Partials 1295 1296 +1 ☔ View full report in Codecov by Sentry. |
ShahakShama
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
ShahakShama
previously approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Reviewable status:
matan-starkware
changed the title
ref mut self
matan-starkware
changed the title
matan-starkware
force-pushed
the
matan/consensus/m3/reorganize_shc_expectations_v2
branch
from
699dc57 to
4323456
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/context_broadcast_mut
branch
from
0c973ac to
e0d1548
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/reorganize_shc_expectations_v2
branch
from
4323456 to
d23c070
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/context_broadcast_mut
branch
from
e0d1548 to
317834b
Compare
Base automatically changed from
matan/consensus/m3/reorganize_shc_expectations_v2
to
main
July 22, 2024 13:11
matan-starkware
dismissed
ShahakShama’s stale review
The base branch was changed.
matan-starkware
force-pushed
the
matan/consensus/m3/context_broadcast_mut
branch
from
317834b to
9da4700
Compare
ShahakShama
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
…mut self' This allows us to remove the Arc<Mutex> and also avoid cloning the sender on every call. The cost is that we leak the fact that futures Sender requires .
matan-starkware
force-pushed
the
matan/consensus/m3/context_broadcast_mut
branch
from
9da4700 to
d0f50df
Compare
dan-starkware
pushed a commit
that referenced
this pull request
Jul 23, 2024
…mut self' (#2241) This allows us to remove the Arc<Mutex> and also avoid cloning the sender on every call. The cost is that we leak the fact that futures Sender requires .
dan-starkware
pushed a commit
that referenced
this pull request
Jul 23, 2024
…mut self' (#2241) This allows us to remove the Arc<Mutex> and also avoid cloning the sender on every call. The cost is that we leak the fact that futures Sender requires .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove the Arc and also avoid cloning the sender on every call.
The cost is that we leak the fact that futures Sender requires .
This change is