refactor(consensus): put expectations near the most relevant call site for SHC tests #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @matan-starkware and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2239 +/- ##
==========================================
- Coverage 66.31% 66.29% -0.02%
==========================================
Files 139 139
Lines 18341 18341
Branches 18341 18341
==========================================
- Hits 12163 12160 -3
Misses 4883 4883
- Partials 1295 1298 +3 ☔ View full report in Codecov by Sentry. |
matan-starkware
force-pushed
the
matan/consensus/m3/pass_context_by_reference_shc
branch
from
422cde3 to
3630e0a
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/reorganize_shc_expectations_v2
branch
from
b895c5c to
ee10c01
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/pass_context_by_reference_shc
branch
from
3630e0a to
9378b37
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/reorganize_shc_expectations_v2
branch
from
ee10c01 to
d8de3fc
Compare
asmaastarkware
previously approved these changes
Jul 21, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
matan-starkware
force-pushed
the
matan/consensus/m3/pass_context_by_reference_shc
branch
from
9378b37 to
9aa2aec
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/reorganize_shc_expectations_v2
branch
from
d8de3fc to
eae77b8
Compare
ShahakShama
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
ShahakShama
previously approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Reviewable status:
matan-starkware
force-pushed
the
matan/consensus/m3/pass_context_by_reference_shc
branch
from
9aa2aec to
d9610d2
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/reorganize_shc_expectations_v2
branch
from
eae77b8 to
699dc57
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/pass_context_by_reference_shc
branch
from
d9610d2 to
069a8a8
Compare
matan-starkware
force-pushed
the
matan/consensus/m3/reorganize_shc_expectations_v2
branch
from
699dc57 to
4323456
Compare
Base automatically changed from
matan/consensus/m3/pass_context_by_reference_shc
to
main
July 22, 2024 10:55
matan-starkware
dismissed stale reviews from ShahakShama and asmaastarkware
The base branch was changed.
…e for SHC tests This is now possible since we no longer put the Context in an Arc, which forced us to set expectations before doing that. Setting expectations requires .
matan-starkware
force-pushed
the
matan/consensus/m3/reorganize_shc_expectations_v2
branch
from
4323456 to
d23c070
Compare
asmaastarkware
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
matan-starkware
deleted the
matan/consensus/m3/reorganize_shc_expectations_v2
branch
dan-starkware
pushed a commit
that referenced
this pull request
Jul 23, 2024
…e for SHC tests (#2239) This is now possible since we no longer put the Context in an Arc, which forced us to set expectations before doing that. Setting expectations requires .
dan-starkware
pushed a commit
that referenced
this pull request
Jul 23, 2024
…e for SHC tests (#2239) This is now possible since we no longer put the Context in an Arc, which forced us to set expectations before doing that. Setting expectations requires .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now possible since we no longer put the Context in an Arc, which forced us to
set expectations before doing that. Setting expectations requires .
This change is