chore: remove deprecated component runner test #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pr/Itay-Tsabary-Starkware/tsabary/cleanups/4c9d9914 #394 +/- ##
====================================================================================
Coverage 83.24% 83.24%
====================================================================================
Files 36 36
Lines 1695 1695
Branches 1695 1695
====================================================================================
Hits 1411 1411
Misses 209 209
Partials 75 75 ☔ View full report in Codecov by Sentry. |
Itay-Tsabary-Starkware
force-pushed
the
pr/Itay-Tsabary-Starkware/tsabary/cleanups/3bb10577
branch
from
3ef7355 to
9fff32f
Compare
Itay-Tsabary-Starkware
force-pushed
the
pr/Itay-Tsabary-Starkware/tsabary/cleanups/4c9d9914
branch
from
6ae3a08 to
8e64414
Compare
uriel-starkware
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/mempool_infra/Cargo.toml line 18 at r2 (raw file):
bincode.workspace = true hyper.workspace = true serde.workspace = true
Is this alphabetizing? Shouldn't be in different commit (Together with the ones done in your other PR)?
commit-id:4c9d9914
commit-id:3bb10577
Itay-Tsabary-Starkware
force-pushed
the
pr/Itay-Tsabary-Starkware/tsabary/cleanups/3bb10577
branch
from
9fff32f to
7841cd4
Compare
Itay-Tsabary-Starkware
force-pushed
the
pr/Itay-Tsabary-Starkware/tsabary/cleanups/4c9d9914
branch
from
8e64414 to
65d0250
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
Itay-Tsabary-Starkware
changed the base branch from
pr/Itay-Tsabary-Starkware/tsabary/cleanups/4c9d9914
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-id:3bb10577
Stack:
This change is