-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move component communication to infra crate #378
refactor: move component communication to infra crate #378
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
+ Coverage 83.21% 83.24% +0.02%
==========================================
Files 36 36
Lines 1692 1695 +3
Branches 1692 1695 +3
==========================================
+ Hits 1408 1411 +3
Misses 209 209
Partials 75 75 ☔ View full report in Codecov by Sentry. |
105e987
to
6ae3a08
Compare
6ae3a08
to
8e64414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/mempool_infra/src/component_definitions.rs
line 22 at r1 (raw file):
pub fn take_tx(&self) -> Sender<T> { self.tx.to_owned().expect("Sender should be available, could be taken only once")
why to_owned
and not take
?
Code quote:
self.tx.to_owned()
crates/mempool_node/Cargo.toml
line 20 at r1 (raw file):
starknet_gateway = { path = "../gateway", version = "0.0" } starknet_mempool = { path = "../mempool", version = "0.0" } starknet_mempool_infra = { path = "../mempool_infra", version = "0.0" }
Is this alphabetizing? Shouldn't be in different commit?
crates/mempool_node/Cargo.toml
line 24 at r1 (raw file):
tokio.workspace = true tracing-subscriber = { workspace = true, features = ["env-filter"] } tracing.workspace = true
Is this alphabetizing? Shouldn't be in different commit?
commit-id:4c9d9914
8e64414
to
65d0250
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
✓ Commit merged in pull request #394 |
Stack:
This change is