Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate mempool infra test utils from test #215

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Jun 5, 2024

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/refactor_mempool_infra/866c1c00 branch from 8669ea1 to 7ae2495 Compare June 5, 2024 10:03
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/refactor_mempool_infra/678cdaac branch from 0e00803 to 58ef432 Compare June 5, 2024 10:03
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/refactor_mempool_infra/866c1c00 branch from 7ae2495 to 4151c53 Compare June 5, 2024 10:12
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/refactor_mempool_infra/678cdaac branch from 58ef432 to d716b09 Compare June 5, 2024 10:12
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (4151c53) to head (d716b09).

Additional details and impacted files
@@                                        Coverage Diff                                         @@
##           pr/Itay-Tsabary-Starkware/tsabary/refactor_mempool_infra/866c1c00     #215   +/-   ##
==================================================================================================
  Coverage                                                              67.39%   67.39%           
==================================================================================================
  Files                                                                     25       25           
  Lines                                                                    917      917           
  Branches                                                                 917      917           
==================================================================================================
  Hits                                                                     618      618           
  Misses                                                                   273      273           
  Partials                                                                  26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants