Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate component definitions from component server #213

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Jun 4, 2024

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/refactor_mempool_infra/56f63265 branch from 28e4bd4 to d60a69f Compare June 5, 2024 10:02
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the title build: separate component definitions from component server chore: separate component definitions from component server Jun 5, 2024
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/refactor_mempool_infra/56f63265 branch from d60a69f to 284efc0 Compare June 5, 2024 10:03
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (4744e13) to head (07653cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   67.39%   67.39%           
=======================================
  Files          25       25           
  Lines         917      917           
  Branches      917      917           
=======================================
  Hits          618      618           
  Misses        273      273           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/refactor_mempool_infra/56f63265 branch from 284efc0 to 07653cc Compare June 5, 2024 10:12
Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants