Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FunctionCallConcreteLibfunc to SignatureAndFunctionConcreteLibfunc. #4615

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

liorgold2
Copy link
Collaborator

@liorgold2 liorgold2 commented Dec 20, 2023

This change is Reviewable

@liorgold2 liorgold2 requested a review from orizi December 20, 2023 12:05
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/coupon-arg/53baa46f branch from 23b5220 to 22dd176 Compare December 20, 2023 12:47
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/coupon-arg/c7ed8ab4 branch from 8d17920 to 0d656bb Compare December 20, 2023 12:47
@liorgold2 liorgold2 changed the base branch from pr/liorgold2/lior/coupon-arg/c7ed8ab4 to coupons December 20, 2023 13:04
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/coupon-arg/53baa46f branch from 22dd176 to 57723a1 Compare December 20, 2023 13:04
@liorgold2 liorgold2 enabled auto-merge December 20, 2023 13:04
@liorgold2 liorgold2 added this pull request to the merge queue Dec 20, 2023
Merged via the queue into coupons with commit 74371e1 Dec 20, 2023
39 checks passed
@orizi orizi deleted the pr/liorgold2/lior/coupon-arg/53baa46f branch December 21, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants